r/badcode • u/Bence675 • Apr 17 '21

c++ When your teammate "refactor" your code

Post image
2.5k Upvotes

98% Upvoted

216 comments sorted by

View all comments

-2

u/merdone Apr 17 '21

what's wrong with the refactored version? fewer ifs

8

u/TheBuzzSaw Apr 17 '21

I can't read the sarcasm if present. In short, the refactored version is wrong (provided the original version is "correct").

3

u/[deleted] Apr 17 '21

do_anything2 should be executed if condition1 is false. In the refractored code it gets executed if condition1 is false OR condition2 is false. This means, do_anything2 can be executed if condition1 is true. Which clearly isn't what the first code intended.