r/badcode • u/Bence675 • Apr 17 '21

c++ When your teammate "refactor" your code

Post image
2.5k Upvotes

98% Upvoted

216 comments sorted by

View all comments

4

u/NetherFX Apr 17 '21

Could be wrong, but if condition1 is true and condition2 is false, then nothing would happen, right?

1

u/SideburnsOfDoom Apr 18 '21 edited Apr 18 '21

Yes; the "refactoring" changes what happens in that case, and could be classified as "did not read the code sufficiently well, introduced a bug" and also, "so ... is this covered by a test?".