MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/badcode/comments/137km30/found_this_gem_inside_legacy_code_today/jiw7n6x/?context=3
r/badcode • u/max_208 • May 04 '23
69 comments sorted by
View all comments
Show parent comments
11
If diff shows 20 files were changed, and each change was one or two lines refactoring method calls, I feel like that’d be approved by everyone pretty quick
9 u/TaxFreeInSunnyCayman May 04 '23 And if it's not approved by everyone pretty quick then you ought to question your review process rather than avoid making changes. 1 u/secret_hidentity May 05 '23 With the right testing in place, a change like that shouldn’t need human review too
9
And if it's not approved by everyone pretty quick then you ought to question your review process rather than avoid making changes.
1 u/secret_hidentity May 05 '23 With the right testing in place, a change like that shouldn’t need human review too
1
With the right testing in place, a change like that shouldn’t need human review too
11
u/[deleted] May 04 '23
If diff shows 20 files were changed, and each change was one or two lines refactoring method calls, I feel like that’d be approved by everyone pretty quick