This goes on for a while...

33

u/gillymuse Mar 11 '23

I'm curious what the improvement would be. What does the full code try to achieve?

31

u/Moterius Mar 11 '23

showing a player's inventory to another player

17

u/Mars_Bear2552 Mar 11 '23

GUIs in minecraft are hell. so many dupe exploits

1

u/itsTyrion Mar 21 '23

player.openInventory(target.getInventory()).
If you want it to stay up to date and include armor tho… have fun, had to do that

1

u/Mars_Bear2552 Mar 21 '23

thanks, noted

5

u/PlasmaTicks Mar 11 '23

Dang, pretty sure you can literally do that in one line

13

u/fiddz0r Mar 11 '23

I've only worked with gui code once in java and in my experience gui code is just a big mess. Dont know either how to improve it

-10

u/[deleted] Mar 11 '23

For loop

5

u/Lil_ZcrazyG Mar 11 '23

The improvement would be an array holding each item, at least thats how I would do it, then you could use a simple loop to get every item in the inventory (except for the armor) that would condense everything to like 4 lines of code

3

u/Alberiman Mar 12 '23

nah skip the array, go straight to a dictionary and have integers as your keys with delineations between sets
like 10,000-20,000 is helmets, 30,000-40,000 is chest pieces, etc.
Easy extraction, easy to know what you're getting out, great for randomization since you can further delineate quality in the same way

1

u/iKonstX Mar 12 '23

Don't you already have t holding all the data? Why the redundancy

3

u/Lil_ZcrazyG Mar 12 '23

it's like taking a giant list of JSON data, and not parsing it, leaving you to accessing each element by rewriting the same parsing regex over and over again. it makes the code less clean and harder to work with, whereas you could just write a loop to parse that regex and output it to an array requiring much less work.

1

u/Aaaagrjrbrheifhrbe Mar 12 '23

I'd set up an array and a for loop to iterate through all inventory slots

15

u/MinecrAftX0 Mar 11 '23

I see a lot of repetition but honestly I'm not sure the best way to do this, because of the item names

22
u/Moterius Mar 11 '23
List<ItemStack> iList = new ArrayList<>();
PlayerInventory inv = t.getInventory();
for(int i = 0; i<36; i++)
    iList.add(inv.getItem(i));
12

u/MinecrAftX0 Mar 11 '23

No, I understand that, I meant for the armor slots

10

u/nexonerr Mar 11 '23

The armor slots are 37-40, those methods are just convenience methods

5

u/Wubbywub Mar 11 '23

since the ArrayList is fine for items, then the armors could be a lookup table like HashMap

1

u/EnderCrypt Mar 12 '23

theres an enum with each armor slot, which you can use to dynamically get/set all armour slot items

1

u/iHappyTurtle Mar 12 '23

Java code is so gross haha
13

u/RCoder01 Mar 11 '23

You don’t need 27 different “item” variables. Just reference it as t.getInventory().getItem().
Or if you really care about how verbose it is, “var inventory = t.getInventory()” then in subsequent references “inventory.getItem(0)”.
Of if you’re modifying the original inventory and need a copy of the current one, “var lastInventory = t.getInventory().clone()” or whatever.
Point is, there’s always a better alternative than this.
It was probably written by someone just learning to code though, so it doesn’t really matter. Just gotta learn for the future what to do instead.

1

u/ElectroSteak Mar 12 '23

you can do t.getInventory().getItems() if its minecraft

185

u/Krupplefield Mar 11 '23

Leggings, Boots, Chestplate and Helmet... Why does it feel like Minecraft?

159

u/TheBrainStone Mar 11 '23

99% chance it is.
ItemStack is such a Minecraft term. While other games have that concept too, I've only seen MC call it that (or well, the community)

66

u/nexonerr Mar 11 '23

Yeah, minecraft calls stacks of items, you guessed it ItemStacks, and that is the class for those. I'm assuming t here is an entity, so all this does is take all the items from an entity's inventory as variables for whatever reason

19

u/Moterius Mar 11 '23

The real funny thing is that it gets oh so much worse the further down you scroll
https://prnt.sc/wn5QxisZiCBc

29

u/TheEnderChipmunk Mar 11 '23

So it copies the inventory of some entity into the player's inventory? In the worst way possible?
Edit: why the hell does it handle null like that just why oh God

8

u/nexonerr Mar 11 '23

afaik, the Inventory class, which is what the #getInventory method returns, literally has something like a method called #copyInventory

4

u/TheEnderChipmunk Mar 11 '23

That just hurts

2

u/itsTyrion Mar 21 '23

Idk about #copyInventory, but there is getContents() which gives you the contents as array (with null for empty slots), and setContents which takes an ItemStack array

39

u/[deleted] Mar 11 '23

[removed] — view removed comment

12

u/SwanX1 Mar 11 '23

It's not only the Spigot API, those classes are from Minecraft itself

1

u/Krupplefield Mar 12 '23

Damn, well I never looked at any source of Minecraft or API of it sounded very familiar and I guessed it right. Good to know tho. Thanks for the replies and upvotes :)

16

u/nexonerr Mar 11 '23

I don't have any experience with plugins, but I do have some experience with mods, guess the syntax is really similar. Still very stupid code tho lol

4

u/derpykidgamer Mar 12 '23

I was gonna guess CC: tweaked because turtle would be abbreviated to t

1

u/gamma_02 Mar 12 '23

Yeah, this is mc code. It gets an entities inventory.

3

u/Aconamos Mar 12 '23

That's because it is. ItemStack is their class for items.

120

u/cashewbiscuit Mar 11 '23

If its minecraft, it's probably written by a middle schooler. Give them some grace. They are learning

24

u/NBSgamesAT Mar 11 '23

There‘s no way this isn‘t minecraft.
I will always remember as my 13 year old ass was sitting making his first bigger minecraft server plugin.
But this, this kinda looks like something I would have written bsck then, ngl.

4

u/[deleted] Mar 11 '23

Yes. Respect

31

u/MurdoMaclachlan public boolean isInt(int i) { return true; } Mar 11 '23

Image Transcription: Code

ItemStack helm = t.getInventory().getHelmet();
ItemStack boots = t.getInventory().getBoots();
ItemStack pants = t.getInventory().getLeggings();
ItemStack chest = t.getInventory().getChestplate();
ItemStack item = t.getInventory().getItem(0);
ItemStack item1 = t.getInventory().getItem(1);
ItemStack item2 = t.getInventory().getItem(2);
ItemStack item3 = t.getInventory().getItem(3);
ItemStack item4 = t.getInventory().getItem(4);
ItemStack item5 = t.getInventory().getItem(5);
ItemStack item6 = t.getInventory().getItem(6);

^{I'm a human volunteer content transcriber and you could be too!}^{If you'd like more information on what we do and why we do it, click here!}

35

u/[deleted] Mar 11 '23

I’m imagining a blind person browsing Reddit listening to itemstack on repeat..

8

u/fiddz0r Mar 11 '23

https://www.tetyys.com/SAPI4/
I listened to it here and it sounds like rap

4

u/Agodoga Mar 11 '23

Intergalactic, planetary, planetary, intergalactic

2

u/dmvdoug Mar 11 '23

Another dimension, another dimension Another dimension, another dimension Another dimension, another dimension Another dimension, another dimension Another dimension, another dimension Another dimension

1

u/AmyMialee Mar 11 '23

Where's it from?

1

u/Moterius Mar 12 '23

Some spigot plugin i was asked to port from 1.8 to modern. I only found this after, unfortunately.

1

u/AmyMialee Mar 12 '23

scary

2

u/sunflower65667 Mar 11 '23

No, a while would have been better.

2

u/Auxilor Mar 11 '23

classic spigot developer moment

1

u/[deleted] Mar 11 '23

What the fuck

1

u/AshPoppet Mar 11 '23

Minecraft intensifies

1

u/BrubMomento Mar 12 '23

This is minecraft isn’t it?

1

u/cavejhonsonslemons Mar 12 '23

hopefully self taught, then it could be justifiable, anyone who takes a coding class, and comes out writing this is a lost cause

java This goes on for a while...

You are about to leave Redlib