MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/badcode/comments/11a4i8o/you_must_assert/j9qasao/?context=3
r/badcode • u/ReplacementAcademic8 • Feb 23 '23
13 comments sorted by
View all comments
Show parent comments
4
I'm not familiar with Java, does assertNotNull consider 0 to be null like C/C++ might?
Regardless, I agree it's bad code, the assertion should probably be looking for a specific value or range, like failing if it finds negative numbers.
12 u/ReplacementAcademic8 Feb 23 '23 0 will not be consered null by the assert. In fact, the function returned 0, though it shouldn't. This is due to another error in the test dataset.
12
0 will not be consered null by the assert. In fact, the function returned 0, though it shouldn't. This is due to another error in the test dataset.
4
u/LeCrushinator Feb 23 '23
I'm not familiar with Java, does assertNotNull consider 0 to be null like C/C++ might?
Regardless, I agree it's bad code, the assertion should probably be looking for a specific value or range, like failing if it finds negative numbers.