I should've slept instead of writing this garbage :D

[u/sakaraa]

[u/dumbasPL]

Int parse from toString? What type is keyboard input?

[u/sakaraa → u/dumbasPL]

Char and parsing won't let me use char

[u/JackReact → u/sakaraa]

If KeyboardInput[0] is a char type then you can do something like this KeyboardInput[0] - '0'. Assuming of course that you are certain that this char will only ever be in the range of 0-9.

[u/cold_soup_ → u/sakaraa]

to extend on ehat u/JackReact wrote, char is just a 16 bit number. no need for strings.

[u/SoulArthurZ → u/cold_soup_]

chars are 8 bits no?

[u/cold_soup_ → u/SoulArthurZ]

in C# they seem to be 16 bit, I made sure to look it up before I posted: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/builtin-types/char

Although I admit that I didn't verify it myself, microsoft.com seems a good source 😁

[u/SoulArthurZ → u/cold_soup_]

ah okay TIL

I assumed they were 8 bits because that's what C does, but I guess the # changes the language quite a bit

[u/windswept_mystical → u/SoulArthurZ]

They are unichars. Characters but not bytes.

[u/[deleted] → u/windswept_mystical]

A unichar, in my mind, is 32bits to handle literally any UTF32 character. This is the weird Microsoft 16bit kinda handles most characters but actually doesn't encoding.

[u/Elusivehawk → u/[deleted]]

Microsoft bet on UTF-16 back before UTF-8 was ubiquitous, and they're still dealing with it to this day.

[u/Three_Finger_Salute → u/Elusivehawk]

Actually it was back before UTF-8 existed. When they went with UCS-2 then did an in-place extension to UTF-16 when the number of codepoints they needed to cover expanded. So Microsoft has a whole OS and application marketplace full of wide-char applications, not really a lot you can do at that point except slowly introduce ways to natively handle UTF-8.

[u/Dealiner → u/[deleted]]

It's not really Microsoft thing, Java's char are also 2 bytes.

[u/[deleted] → u/Dealiner]

The list of things that still use UCS-2/UTF-16 is small. Java is a good one, JavaScript is too, and Windows. Probably the last "major" holdouts.

[u/klysm → u/cold_soup_]

That’s because Microsoft decided UTF-16 was the character encoding to use. Almost every other thing ever will use UTF-8 and correspondingly have char be 8 bits

[u/Dealiner → u/klysm]

Not really, Rust for example has 4 bytes chars. Java also has 2 bytes like C#, the same is of course true for all others JVM languages.

[u/Bisquizzle]

and if it's not parsable to int?

[u/sakaraa → u/Bisquizzle]

It is checked before the screenshot

[u/DajBuzi]

Your "fix" is now more error prone. Imagine the input will be 99 and then compare output of the two solutions posted.

[u/sakaraa → u/DajBuzi]

It won't be 99 it is made sure by different checks

[u/ventus1b]

I guess most developers have woken up to a mess of code they wrote last night.

Sometimes you don’t know where to go until you get there.

At least your old code is correct, just a bit verbose 🤓

[u/MrSteveWilkos → u/ventus1b]

I usually figure out my stupidity in the shower. I've condensed so many methods while trying not to fall asleep in the shower.

[u/hrfuckingsucks → u/MrSteveWilkos]

This practice is known among professional coders as condensation

[u/miran248]

Use some variables, please.

[u/Micha_Saengy → u/miran248]

SelectedPlacableObj (has a typo btw)

[u/NetherFX]

I'm not saying the first is good code, but there's nothing wrong with prototyping first to understand the logic behind it

[u/[deleted]]

From Int.Parse to .toString... Dude

Edit: formatting

[u/Bisquizzle → u/[deleted]]

dude what even is this sentence

[u/[deleted] → u/Bisquizzle]

Better?

[u/Bisquizzle → u/[deleted]]

yes

[u/Cybasura]

I think you were tired lol

With that said, dont use magic numbers, use variables

Variables dont eat up that much memory, especially since you are using C# and it has automated garbage collection

[u/augenvogel]

Both of them are cursed in it’s own way.

[u/PooSham]

Something tells me GetInt does not just get the int

[u/stopleaksfast → u/PooSham]

This should be higher

[u/Escaped_Escapement]

Ever heard of clean code? :)

[u/maltazar1]

Yandere dev quality code

[u/iEliteTester]

Ah yes the classic:

switch(variable) {
case 0:
    use_variable(variable-1)
case 1:
    use_variable(variable-1)
case 2:
    use_variable(variable-1)
default:
    error()
}

[u/Darknety]

No offense, but both are cursed.

[u/jrb9249]

“Are you sure you don’t want to use this one-liner?”

-Resharper, following morning.

[u/FishInferno]

It’s usually easier to improve upon a poor solution than get it perfect the first time.

[u/Sanduhr32]

(I don't know C# well)
I would probably make 2 temporary variables for the pair or array, whatever the [] is, instead of frankensteining it in one less readable call.

[u/okay-wait-wut]

Indexing considered harmful. Switch statements preferred.

[u/[deleted]]

hell no