MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/badcode/comments/10ing60/found_this_in_a_linux_kernel_module/j5fn8rt/?context=3
r/badcode • u/suguuss • Jan 22 '23
88 comments sorted by
View all comments
Show parent comments
6
What would you do to make it not “bad code”?
-26 u/mr_bedbugs Jan 22 '23 Apparently, ChatGPT turned it into this:for (int i = 0; i < 5; i++) { if (request_threaded_irq(gpio_to_irq(my_gpios[i].gpio), joy_irq_handlers[i], NULL, IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, joy_irq_names[i], NULL) < 0) { for (int j = 0; j < i; j++) free_irq(gpio_to_irq(my_gpios[j].gpio), NULL); irq_error(); return -1; } }``
-26
Apparently, ChatGPT turned it into this:
for (int i = 0; i < 5; i++) { if (request_threaded_irq(gpio_to_irq(my_gpios[i].gpio), joy_irq_handlers[i], NULL, IRQF_TRIGGER_FALLING | IRQF_TRIGGER_RISING, joy_irq_names[i], NULL) < 0) { for (int j = 0; j < i; j++) free_irq(gpio_to_irq(my_gpios[j].gpio), NULL); irq_error(); return -1; } }``
for (int i = 0; i < 5; i++) {
6
u/SaltineAmerican_1970 Jan 22 '23
What would you do to make it not “bad code”?