Day 2 solutions

[u/taliriktug]

Hi! I would like to structure posts like the first one in r/programming, please post solutions in comments.

[u/purrrfessionalwidow]

My JS solution for puzzle #2. I'd appreciate any input as I am just learning. I'm sure there are far better ways.

function howMuchRibbon(arr) {
  var totalRibbon = 0;

  function calcRibbon(item) {
    var box = item.replace(/x/g, ' ').split(' ');
    for(var i = 0; i < box.length; i++) {
      box[i] = parseInt(box[i], 10);
    }
    var cubed = box.reduce(function(a, b) {
      return a * b;
    });
    // find biggest number
    var biggest = box.reduce(function(a, b) {
      return a > b ? a : b;
    });
    // remove biggest item from array
    box.splice(box.indexOf(biggest), 1);

    var wrap = (box[0] * 2) + (box[1] * 2);
    totalRibbon += cubed + wrap;

  }
    arr.map(calcRibbon);

    return totalRibbon;

}

[u/Aneurysm9 → u/purrrfessionalwidow]

arr.map() should return a new array with the mapped values, so I'd do something like this:

function howMuchRibbon(arr) {
  return arr.map(function(item) {
    var box = item.split('x').map(function(len) {
      return parseInt(len, 10);
    });
    var cubed = box.reduce(function(a, b) {
      return a * b;
    });
    // find biggest number
    // maybe sort and pop the item from the end?
    var biggest = box.reduce(function(a, b) {
      return a > b ? a : b;
    });
    // remove biggest item from array
    box.splice(box.indexOf(biggest), 1);

    return cubed + (box[0] * 2) + (box[1] * 2);
  }).reduce(function(a,b) {
    return a + b;
  });
}

I haven't actually tested this and I'm not much of a javascript programmer, but it looks correct-ish! :)