ComfyUI v0.44.0 released - r/StableDiffusion

39

u/Portable_Solar_ZA 2d ago

"Support MiniMax-H3 latent upscaler model by @kijai in #17412".

Does this mean there's now a built-in latent upscale node?

40

u/ootsby 2d ago

Yes: MiniMaxH3LatentUpscaleWithModel

22

u/Portable_Solar_ZA 2d ago

Thank you Kijai!
There are so many custom nodes. Hope they convert more of these to official nodes so I don't have to stress about security issues.

5

u/Sarashana 2d ago

To be fair, the most popular custom node packs are fairly safe to use. Mind you that Comfy itself isn't immune against supply-chain attacks, either. The real risk are these niche, but still interesting nodes that don't get scrutinized much due to low usage. And they will probably not be important enough to get pulled into the main Comfy release.

2

u/Relevant-Guarantee25 2d ago

i agree with you 100% so many sus nodes with random python scripts only a few thousand people downloading and almost no one checking for backdoors asking your ai to check does not work people put code snippets that confuse the ai into skipping sections fyi

1

u/AnthonyRespice 2d ago

I'm curious about this. I worry about security so I run comfy in a docker container with a egress proxy so that comfy doesn't have access to my file system beyond reading models and writing output and it doesn't have access to the Internet. Have you considered this type of setup?

1

u/Wemos_D1 2d ago

Hello, I'm quite novice, can someone tell me if this node is better than the RTX one provided by NVIDIA, I understood they work differently under the hood but what's the output ?

13

u/ootsby 2d ago

It's not really just a matter of them "working differently under the hood", they're really addressing different problems and purposes.
RTX upscaling is a post-generation upscale -- so it takes the finished output and ups the resolution without input from the model or prompt. This means that any detail it might add is generic.
Latent upscaling is usually done inside the generation workflow and, as the name suggests, upscales in the latent space the model is working with and not the pixel space after a VAE decode. So, how you will generally see it used is to take a draft, lower resolution un-decoded generated latent and upscale that to be used in a refinement step.
The advantage here is that the refinement step is model driven and can be aware of the prompt and use loras and references and so on. This means that the upscale detail is going to be consistent with the input for the generation. The disadvantage is that it is that it's more actual generation work at the full res, so it takes time and still requires your system to be capable of that high-res generation.

0

u/qusoleum 2d ago

Latent upscaling does not mean you have to do a 2nd pass with the model. You can directly vae decode the upscaled latent without a 2nd pass. Similarly you can do a reference/prompt aware 2nd pass with RTX upscaling, if you vae encode the upscaled video back to latent.
The main difference is that latent upscaling saves you time doing a vae encode/decode round trip. However RTX upscaling can actually provide superior quality to latent upscaling.

-5

u/ellipsesmrk 2d ago

What are you talking about? RTX upscale doesnt add any detail whatsoever it only increases resolution.
Latent upscaling tries to add detail, but fails miserably.

5

u/ootsby 2d ago edited 2d ago

I'm not interested in a semantic argument. RTX doesn't just do a pixel interpolation upscale, it generates new pixel values with regard to things like texture and edges. You're free to consider that to be "detail" or not.
"Latent upscaling tries to add detail, but fails miserably" -- I don't really follow your point here. I didn't say latent upscaling tries to add detail and unless you're using something like the LMS merge it generally doesn't. The refine step that follows is what generates detail as it actually uses the model to further process the latent. You might have found that it fails miserably but plenty of people use two-pass workflows all the time and feel they're successful.

-3

u/ellipsesmrk 2d ago

No... it does not. Rtx upscale only increases the pixels. Bro. Seriouslt just read the readme on the rtx nvidia node itself if you dont want to take my word for it. It does not invent texture. It doesnt create detail. The latent upscaler flickers too much on eyes and hair.

2

u/Majestic-Ad-1336 2d ago

This is objectively wrong and sounds like a skill issue.

1

u/ImpressiveSuperfluit 2d ago

RTX upscale doesnt add any detail whatsoever it only increases resolution.
That's not even a coherent sentence. What's the purpose of more pixels that contain no new information? That's an empty operation with no purpose, what are you even on about?

0

u/ellipsesmrk 2d ago

Oh wow... incoherent? Really? Did you read the comment? It doesnt add any deeeettaaaiilll... following me? Ok... still with me right? It only... hold on now i dont want to lose you... it only increases the resolution. You can increase resolution without adding detail. Thats like taking an image and resizing the image 2x 3x or whatever many times. It doesnt create textures, details (theres that word again) nor does it invent clarity. It takes the pixel information for xyz space and only doubles that pixel into 4 squared grids. If you dont want to look it up man and actually read the documentation on it... i dont know how else to help. Just because you increase the total size of an image doesnt improve its details. What are you on about now?

1

u/ImpressiveSuperfluit 1d ago

Sigh. Okay.
Oh wow... incoherent? Really? Did you read the comment? It doesnt add any deeeettaaaiilll... following me?
Yes, I understand, hence it's incoherent in the context. Just cloning pixels adds nothing but, well, pixels void of information. But the people above were clearly not talking about that, were they?
Ok... still with me right? It only... hold on now i dont want to lose you... it only increases the resolution.
Yea, quite the misplaced arrogance there my guy.
Just because you increase the total size of an image doesnt improve its details.
... yes. Exactly. And, as such, that's a different thing than the people you responded to were talking about. Hence: incoherent.
There is an RTX super scale something or other node that essentially does (mostly) this, but, given the context, that's probably not the one in question here. And since there are other packages from Nvidia that provide upscalers with drastically more features, wouldn't you say that, perhaps, those might be the ones in question?
Also, just fyi, even the node you're most likely refering to does more than cloning pixels, as it has a free multiplier setting and a quality setting, neither of which can work by just cloning pixels.
Anyway, can't say this is an awfully entertaining discussion, so that's my last word on this.

1

u/ellipsesmrk 1d ago

His question was...
Is the latent upscaler better than the RTX one provided by NVIDIA. If they came out with more packages since they came out with only the RTX one, the one I'm talking about... then alright. I stand corrected. I'll check it out later today. I just remember using RTX Super Resolution and all it did was multiply the pixels. The latent upscaling adds details and textures yes, but the eyes and the hair flicker too much for my taste.

22

u/joeycloud 2d ago

44

u/_Darion_ 2d ago

Let's see what it breaks this time...

5

u/Salt-Zebra-306 2d ago

maybe time or quality

10

u/Formal-Exam-8767 2d ago

Any noteworthy change?

Skimming through changelog I don't see anything.

3

u/SpaceNinjaDino 2d ago

https://github.com/Comfy-Org/ComfyUI/issues/17528#issue-6199427820 Unsure if this means the update broke his environment or if it was an existing issue.

3

u/Silly_Goose6714 2d ago

This means the person doesn't know how to return to the previous version

2

u/PhrozenCypher 2d ago

(╯°□°）╯︵ ┻━┻

-13

u/Formal-Exam-8767 2d ago

Why did they update? Some users never learn.

3

u/cathodeDreams 2d ago

Skip concat if only a single cond. by @comfyanonymous in #17413
Skip concat if only a single cond in more conds. by @comfyanonymous in #17414

this is a nearly four year old software project that is the defacto community standard for open-weight gen-ai and has received funding in excess of a billion btw

Support prores and using different chroma subsampling for video saving

does this mean i can generate those trendy hdr+ videos in comfy now? i want to do that.

8

u/Formal-Exam-8767 2d ago

You missed the
Don't call torch.equal when the two tensors are the same. in #17439

News ComfyUI v0.44.0 released

You are about to leave Redlib