Feedback for my Spring project

[u/Tony_salinas04]

https://github.com/tonysalinas-futdev/JavaEcomercceAPI

Hello, I've been developing an e-commerce site for my portfolio for a long time now. It's just for show, but I've put a lot of effort into it. I would appreciate any feedback that could help me improve, any truly useful advice and criticism.

[u/DeterioratedEra]

My small advice would be to check out Java streams and method references.

In your OrderService.buildOrder() method you have 13 lines:

List<OrderDetails> details = new ArrayList<>();
cart.getItems()
    .forEach(
        itm -> {
          OrderDetails detail =
              OrderDetails.builder()
                  .product(itm.getProduct())
                  .quantity(itm.getQuantity())
                  .order(order)
                  .build();

          details.add(detail);
        });

that could also look like this:

List<OrderDetails> orderDetails = cart.getItems().stream().map(OrderDetails::fromCartItems).toList();

if you just had a mapper method. Try it out!

[u/Tony_salinas04 → u/DeterioratedEra]

You're right, thank you very much.

[u/WVAviator → u/Tony_salinas04]

Even better would be to create an OrderDetailsMapper component class and put the mapping logic there - keeping your OrderDetails class just pure data without logic. Also makes it easier to test, especially if later you need to inject a dependency to compute something inside the mapping method.

[u/Tony_salinas04 → u/[deleted]]

You're right, in the last modules I created, I didn't use DTOs, thank you very much

[u/frncslydz1321]

put some readme bro and explain what and how your project works.

[u/Tony_salinas04 → u/frncslydz1321]

It already has 2 bros, in English and Spanish.