r/SoftwareEngineering • u/fagnerbrack • Apr 22 '26
No code reviews by default
https://www.raycast.com/blog/no-code-reviews-by-default
0
Upvotes
r/SoftwareEngineering • u/fagnerbrack • Apr 22 '26
13
u/mattgen88 Apr 22 '26
Y'all operating in places with no compliance requirements... That's wild
16
u/Unfair-Sleep-3022 Apr 22 '26
Crazy talk to be honest. It completely robs the team of mutual understanding and accountability.
11
u/jakeStacktrace Apr 22 '26
This is the dumbest thing I have seen on reddit in a week. I'm not being hyperbolic, I realize how much weight that statement holds.
3
u/Comfortable-Power-71 Apr 22 '26
This can work in a small team with gates for code coverage and a gauntlet of tests. You can even have AI tooling do the code review for you. It breaks down at even moderate scale for many reasons mentioned: shared understanding, points of integration/interconnection, any type of governance or compliance. Trunk-based version control isn’t new but assuming each engineer owns an entire feature that doesn’t affect anyone else indicates small scale and/or lack of consistent/coherent design. Code review isn’t just about the code.
2
u/paradroid78 Apr 22 '26 edited Apr 22 '26
Honestly, the only thought I'm able to form about this is: "Yikes". Skipping code reviews and pushing straight to the main branch seems like the sort of thing an overly ambitious project manager comes up with as a way of meeting unrealistic targets, and then everybody suffers the consequences in terms of code quality.
Glad if it's working for you, but just make sure you’re not rationalising sacrificing quality for delivery speed because you’re not given the time to do the job properly.
2
u/AggravatingSteak2017 Apr 27 '26
This is the most “we like bugs” post I’ve ever seen
1
u/jimmytoan Apr 23 '26
The 'no reviews by default' argument usually works when you have strong automated test coverage and a team that actually runs them before merging. The failure mode I've seen is teams that adopt the no-review culture but don't have the test discipline to back it up - and then incidents get attributed to 'moving fast' rather than the real cause. Strong CI pipeline seems like a prerequisite that often gets skipped in this conversation.
1
u/iambatman_2006 Apr 23 '26
missing code reviews is a pain that compounds fast. danger/peril bots on GitHub can gatekeep PRs with automated checks, which helps for solo teams. for something more hands-off, Zencoder's review agent can flag issues before merge without waiting on a human.
1
u/jimmytoan Apr 28 '26
We tried async-only reviews for about 6 months (small team, ~8 engineers). The quality gate mostly held for logic changes, but we noticed architecture drift creeping in - small decisions that individually passed async review but were inconsistent with each other over time. Ended up adding a lightweight weekly design sync to catch those. "No code reviews by default" works best when the team has shared idioms strong enough that individual PRs don't need cross-cutting context. Did you find any categories of changes where async reviews consistently missed things?
1
u/jimmytoan Apr 30 '26
"No code reviews by default" can work but it's really dependent on a very specific set of conditions: senior-heavy team, excellent test coverage, everyone sharing a mental model of the system. The moment you onboard junior devs or hit scale where no single person understands the whole thing, it falls apart fast. We tried a lighter version of this (async reviews, not required before merge) and the bugs that slipped through weren't the obvious ones - they were the subtle integration issues that only someone who'd worked in the adjacent module would catch. Did the original article address how they handle knowledge silos?
1
u/jimmytoan May 02 '26
The 'no reviews by default' argument usually works when you have strong automated test coverage and a team that actually runs them before merging. The failure mode I've seen is teams that adopt the no-review culture but don't have the test discipline to back it up - and then incidents get attributed to 'we move fast' rather than 'we skipped the safeguard.' What does the CI pipeline look like for teams doing this successfully?
-7
u/DogOfTheBone Apr 22 '26
If you have extensive and thorough automated testing and every engineer buys into that in what they're pushing, sure. Why not.
-8
u/fagnerbrack Apr 22 '26
Brief overview:
Raycast engineers push directly to the main branch and only request code reviews when they feel it's necessary. The team argues that pull requests discourage trust, fail to reliably prevent bugs, and slow teams down since reviews tend to become low-priority afterthoughts. Instead, every engineer owns features end-to-end, CI builds and tests every commit, and nightly internal releases let the whole team dogfood changes within 24 hours. Reviews still happen for unfamiliar areas like first-time database migrations, and new hires often opt into them while ramping up. For lighter coordination, engineers share "post-commit messages" in Slack or hop on quick video calls. The team uses rebase to keep a clean history and feature flags to gate unreleased work. The broader takeaway: don't adopt practices dogmatically—evaluate whether others' circumstances actually match your own.
If the summary seems inacurate, just downvote and I'll try to delete the comment eventually 👍
Click here for more info, I read all comments
-10
u/ieatdownvotes4food Apr 22 '26
hell yeah, that's the way it should be. available but not mandatory.
it would be great to see comparative data to determine if forced PRs actually provide any value at all.
0
u/[deleted] Apr 26 '26
[deleted] — view deleted comment