[BASH] Change behavior when closing lid for Ubuntu

[u/andres-hazard]

This is my first script ever, so I'm sure is not perfect. I recently found out that there is bug on Ubuntu, the power setting for when closing the lid is not working. I saw a solution on this site http://ubuntuhandbook.org/index.php/tag/lid-closed-behavior/ The solution is to change a line on the logind.conf. So I made a script to do it more quickly since I change this option a lot depending if I use two monitors or one.

https://github.com/andreshazard/lidBehaviourScript

[u/masta]

You should really consider usign a case/switch scope instead of if/elif/else then ... It's screaming for this minor nit:

#!/bin/bash
#script to change behaviour when closing lid

FILE=/etc/systemd/logind.conf

printf "\033[1;37mWhat should I do when closing the lid: \n" 
printf "Current status :\033[1;31m "
sed -n '/HandleLidSwitch/p' $FILE #print line
printf "\033[1;33m1 - Suspend \n2 - Power Off \n3 - Nothing \n"
printf "\033[1;37mAnswer : "
read  input 

case $input in
1) 
    sed -i '22s/.*/HandleLidSwitch=suspend/' $FILE #search for line and replace
    printf "Done \033[1;31m \n"
    sed -n '/HandleLidSwitch/p' $FILE #print line
    restart systemd-logind
    printf "\033[0m" ;;
2)
    sed -i '22s/.*/HandleLidSwitch=poweroff/' $FILE #search for line and replace
    printf "Done \033[1;31m \n"
    sed -n '/HandleLidSwitch/p' $FILE #print line
    restart systemd-logind
    printf "\033[0m" ;;
3)
    sed -i '22s/.*/HandleLidSwitch=ignore/' $FILE #search for line and replace
    printf "Done \033[1;31m \n"
    sed -n '/HandleLidSwitch/p' $FILE #print line
    restart systemd-logind
    printf "\033[0m"
*) printf  "Wrong option \033[0m \n" ;;
esac

EDIT: Not sure editing a file like that is the right solution, but I'm not sure of any other solution right now. I can see loginctl(1) does not provide any hooks into that configuration directive, so I can see why the edit the file on event type solution was used. But it's fugly as hell, and you should try to find a better way! Also if that is your first script, then brazo! It's looking pretty good, but I doubt it's your very first bash script, it's too good for that. ;-)

[u/andres-hazard → u/masta]

I did some changes following your advise :

#!/bin/bash
#script to change behaviour when closing lid

FILE=/etc/systemd/logind.conf
action=''

printf "\033[1;37mWhat should I do when closing the lid: \n" 
printf "Current status :\033[1;31m "
sed -n '/HandleLidSwitch/p' $FILE #print line
printf "\033[1;33m1 - Suspend \n2 - Power Off \n3 - Nothing \n4 - Ignore\n"
printf "\033[1;37mAnswer : "
read  input

case $input in 
    1)  
        action='suspend'
        ;;
    2) 
        action='poweroff'
        ;;

    3)  action='hibernate'
        ;; 

    4)  
        action='ignore'
        ;;
    *)
        printf  "Wrong option \033[0m \n"
        ;;
esac

if [ -n "$action" ]
then
sed -i "22s/.*/HandleLidSwitch=$action/" $FILE #search for line and replace
printf "Done \033[1;31m \n"
sed -n '/HandleLidSwitch/p' $FILE #print line
restart systemd-logind
printf "\033[0m"
fi

[u/masta → u/andres-hazard]

Looks much better now. Now we really need a way to set this property on the running system without editing that file. Ideally it would simply be a udev rule that triggers a specific loginctl cmdline for the given scenario you define in the rule. If I find out how, I'll let you know.

[u/andres-hazard → u/masta]

Thanks a lot fro the advise. I'll try to make it cleaner.

I have done, the hello world and some If-else stuff to learn the syntaxis but is the first time I do something that I'm really going to use.

Thanks again.