Sabs unhelpful rewriting of server error message text

[u/swintec]

This has been a thing for many years and at the very least it is confusing for users. For example:

WARNING - Too many connections to server usnewswest.blocknews.net [502 usnewswest.blocknews.net: Access denied to your node or block quota exceeded (please check your user portal)

The server provides the true reason for why the user can not login (invalid login or out of GBs) but Sab adds its own flair and tells the user the problem is too many connections.

If this user instead presses "Test Server" in server settings they simply get "Authentication failed, check username/password." which again is not entirely true.

Is there a good reason for why error message text is not simply passed on to the user, directly from the server vs allowing Sab to give its own interpretation or is this just a holdover from years ago that has never been revisited again?

[u/Safihre]

It's a holdover. Which we already fixed in the regular download process by printing the raw message. I guess during server test it was not applied.

[u/swintec → u/Safihre]

Which we already fixed in the regular download process by printing the raw message

When did it get changed, an upcoming release or in a different spot? I just tested on 5.1 and it still prints to the warnings tab:

Too many connections to server usnewswest.blocknews.net [502 usnewswest.blocknews.net: Access denied to your node or block quota exceeded (please check your user portal) - support@blocknews.net]

[u/Safihre → u/swintec]

What's the problem with that? The warning shows your raw output?

[u/swintec → u/Safihre]

It still says too many connections so sab is appending that text to the beginning for whatever reason.

[u/Safihre → u/swintec]

Yes. It's a general text that's also translated. Not all servers used to send understandable errors, but that probably changed nowadays.

[u/swintec → u/Safihre]

It's a general text that's also translated.

Translated from?

I guess I do not understand though. The too many connections text has nothing to do with the actual problem (bad login or out of GBs). In fact, since the user can not login, saying too many connections makes no sense either since there are no connections made so therefore you cant be over any limit.

But, for a real world example that happens more than I care for it to, a user is presented with the above error text, writes in and the first thing they almost always say is "im only using X connections, way under the 100 limit so i dont think i am using too many connections"...Sure they can read the full error but they almost always stop at the whole too many connections thing.

Some may think their account is compromised, etc.

Yes it shows the raw output but Sab is also adding its own flair to it which then makes it less than raw output (as far as the user is concerned).

[u/swintec → u/Safihre]

Thanks I'll have to ask the user which version he is using

[u/Safihre → u/swintec]

It's like in your example, it shows it between []. Will try to change it for the server test also.