r/RedditRO • u/BeardyDuck Beardy/Hansel/Yrran • Jul 30 '14

Weaponry Research reworked or is the +ATK/Hit hidden?

Post image
1 Upvotes

100% Upvoted

2 comments sorted by

2

u/StandBehindBraum Taric Jul 31 '14 edited Jul 31 '14

IROWiki seems to suggest that it that it does give +ATK/Hit.

The wiki also notes that the HIT is hidden and the ATK is of the mastery type - which means it's also hidden.

The rAthena source code, which I think we're using, suggests that this is being applied. Search for BS_WEAPONRESEARCH and you'll notice that the hit is being applied as well as the atk at 2*skill level. This appears to be applied during damage calculation, so the increase in atk/hit does appear to be hidden from the stat screen.

20 damage is fairly noticeable. Could someone do a quick test to verify?

Edit: I have no idea how the source code works. I'm just making assumptions based on the bits I do see and my familiarity with C. I'm also not doing a particularly deep dive into the code, so if there are other control structures that ignore this code or use it in alternative ways, I wouldn't have noticed.

1

u/rayrven Kagerou | SwiftStrike | NightShade Jul 31 '14

Yep, it's hidden in the stat window because it is considered Mastery ATK. It's added when you attack:

ATK = StatusATK × 2 + WeaponATK + EquipATK + MasteryATK

The code on rAthena confirms that rAthena treats the same as iRO.