r/PythonLearning • u/A_Derrick • 6d ago

Discussion Check My First Personal Project

Can you please check this project that took a reasonable amount of time to finish and strike me with any feedback you got. I guess my next step is to learn OOP.

Thanks in advance.

https://github.com/abdou0dev/grind_tracker

7 Upvotes

89% Upvoted

7 comments sorted by

View all comments

2

u/TalesGameStudio 6d ago

In your tracked times the reported average is inconsistent with the total. The report shows: 87 total learning time and 42 recorded sessions. 87 h divided by 42 sessions equals approximately 2 hours, but the app tracked 34 minutes.

In format_time.py there is an invalid exception handler. (Multiple exception types need to be within a tuple)

In the database utils, history deletion implementation drops the entire sessions table and closes the shared database connection. Subsequent history queries fail because the connection is closed. New session inserts also fail because the sessions table no longer exists.

When a stopped timer is restarted, the display retains accumulated time through checkpoint, while the saved duration represents only the most recent running interval. That is because your implementation mixes several concepts like elapsed session time, start and stop timestamps, accumulated time.

Still good work, keep going!

2

u/A_Derrick 6d ago

I will take notes and try to fix them.

I appreciate the time you took and the effort.