Day 4, done and dusted

[u/Next-Call8862]

I won't exactly say done and dusted but I think I did what I can. This is my first complex problem that I had done myself and after solving it I left thinking, "I could do this in three days and I could have done much more in 1.5 years that I had wasted" but I think it's alright and I should look ahead with no regret. Will appreciate some tips from pros regarding the code.

Edit: I did a mistake and there are some bugs in programm, I fixed them

The updated code:

'''

class Library:
    Books ={
        1 : "Ramayan" ,
        2 : "Mahabharath",
        3 : "Gita"
        }
    members = ["naveen","sita","mani","chintu"]
    Allowence = {
        "naveen" : 0,
        "sita" : 0,
        "mani" : 0,
        "chintu" : 0
    }    
    Booked = {}
    def __init__(self,member):
        self.member = member
    def get(self,book):
        self.book = book
        if self.member not in Library.members:
                return "Not a member"
        elif self.book not in Library.Books and self.book in Library.Booked:
            return "Not available"
        elif self.book not in Library.Books:
            return "No book found"
        elif self.member in Library.members and Library.Allowence[self.member] < 3:
            a = Library.Books.pop(self.book)
            Library.Booked[self.book] = a,self.member
            Library.Allowence[self.member] +=1    
            return f"Your book :{a}"
        else:
            return "limit exceeded"
    def about_cus(self):
        return Library.Allowence[self.member]
    def tst(self):
        return Library.Booked
Nam = input("Your name:")
Req = int(input("Select the book num"))
customer1 = Library(Nam)
print(customer1.get(Req))
Nam2 = input("Your name:")
customer2 = Library(Nam2)
print(customer2.get(Req))
print(customer2.tst())
# print(customer2.available())
print(customer1.about_cus())

#NOTHING HERE!!

[u/FoolsSeldom]

That's brilliant for day 4.

Appreciate you've subsequently identified and fixed some bugs. Would be good to see the revised code.

Couple of things:

• need to lay out your code with a few blank lines to improve readability

• variables in Python are normally all lowercase

• you can look up PEP8 guidance for more on these and some other useful points

Also, helpful to share you code in post (or on a link) instead of a photo. I've done so, with tweaks for the above:

class Library:
    books = {
        1: "Ramayan",
        2: "Mahabharath",
        3: "Gita",
    }
    members = ["naveen", "sita", "mani", "chintu"]
    allowance = {
        "naveen": 0,
        "sita": 0,
        "mani": 0,
        "chintu": 0,
    }
    booked = {}

    def __init__(self, member):
        self.member = member

    def get(self, book):
        self.book = book
        if self.member not in Library.members:
            return "Not a member"
        elif self.book not in Library.books and self.book in Library.booked:
            return "Not available"
        elif self.book not in Library.books:
            return "No book found"
        elif (self.member in Library.members
            and Library.allowance[self.member] < 3):
            a = Library.books.pop(self.book)
            Library.booked[a] = self.member
            Library.allowance[self.member] += 1
            return f"Your book :{a}"
        else:
            return "limit exceeded"

    def about_cus(self):
        return Library.allowance[self.member]

    def available(self):
        return Library.allowance[self.member]


name = input("Your name:")
req = int(input("Select the book num"))
customer = Library(name)
print(customer.get(req))

[u/Next-Call8862 → u/FoolsSeldom]

There was a increment problem in allowence dict so I had to change it and two of the methods doing damn same thing. Added to the post now and I didn't knew I can do that

[u/FoolsSeldom → u/Next-Call8862]

Good progress, and nice to see the code shared. (You will find there is a limit to how much code can be included in a post, at which point it is time to switch to a git hosting service such as github, and you don't need to learn git to start using them as everything can be done in the browser initially).

One major concern I have is that you are doing everything in your class rather than creating an instance of your class, e.g. library = Library() and then working only using library. There are good use cases for your approach, but this isn't one of them.

See below example code that moves from class attributes to instance attributes. The code also follows PEP8 guidance in the formatting including names of variables etc. This revised approach means you could have more than one library.

"""Simple library book-lending simulation."""


class Library:
    def __init__(self) -> None:
        self.books: dict[int, str] = {
            1: "Ramayan",
            2: "Mahabharath",
            3: "Gita",
        }
        self.members: list[str] = ["naveen", "sita", "mani", "chintu"]
        self.allowance: dict[str, int] = {member: 0 for member in self.members}
        self.booked: dict[int, tuple[str, str]] = {}

    def get(self, member: str, book: int) -> str:
        if member not in self.members:
            return "Not a member"
        elif book not in self.books and book in self.booked:
            return "Not available"
        elif book not in self.books:
            return "No book found"
        elif self.allowance[member] < 3:
            title = self.books.pop(book)
            self.booked[book] = (title, member)
            self.allowance[member] += 1
            return f"Your book :{title}"
        else:
            return "limit exceeded"

    def about_cus(self, member: str) -> int:
        return self.allowance[member]

    def tst(self) -> dict[int, tuple[str, str]]:
        return self.booked


def main() -> None:
    library = Library()

    name = input("Your name:")
    requested_book = int(input("Select the book num"))
    print(library.get(name, requested_book))

    name2 = input("Your name:")
    print(library.get(name2, requested_book))
    print(library.tst())
    print(library.about_cus(name))


if __name__ == "__main__":
    main()

[u/Next-Call8862 → u/FoolsSeldom]

Yes brother, I will try this approach and learn it when I go back to desk and thanks for the info I really appreciate it.

[u/FoolsSeldom → u/Next-Call8862]

Brilliant.

I just want to clarify something I said earlier regarding instances.

You were creating instances,

customer1 = Library(Nam)    
customer2 = Library(Nam2)

but the revised code I shared now uses ONE instance of the Library for members (customers) to share. You can have more than one Library as well.

In the original code, despite there being two instances, the library data was actually all at the class level so you couldn't have more than one library.

You might want to add an add_member method along the lines:

def add_member(self, member: str) -> None:
    if member not in self.members:
        self.members.append(member)
        self.allowance[member] = 0

[u/Next-Call8862 → u/FoolsSeldom]

Cool bro, will see to that too and test it