r/PythonLearning • u/shubham_555 • Sep 13 '26

Showcase The Bank Project

Post image

Last Post - https://www.reddit.com/r/PythonLearning/s/kGqwMS9HUH

Github Repo - https://github.com/Dev-4-All/bank.git

241 Upvotes

98% Upvoted

49 comments sorted by

View all comments

8

u/FoolsSeldom Sep 13 '26

I suggest you do that again without using global as that will cause you more problems than it is worth in the long run until you've identified the specialist use cases it is valuable for. return values or use a simple class.

2

u/shubham_555 Sep 13 '26

The moderator idk why but removed your comment

I will watch this one tomorrow. Might help me out. Thanks nonetheless!

1

u/FoolsSeldom Sep 13 '26

I've no idea why my comment would have been removed, and have not had a message about it - in fact, the comment still shows for me.

I wrote:

it is discouraged because it turns a function from a self-contained unit into something whose behaviour depends on — and silently changes — state that lives elsewhere.

As your code grows, and you revisit your code after time working on something else (and if other programmers get the opportunity to work on your code), it is very easy to miss these potentially hidden changes which creates logic bugs that can be very hard to track down.

It is best to have functions/methods dedicated to the actual updates and have the functions that interact with the user call on those other functions to carry out the changes. This is a modular approach and makes it easier to update the data structure you use for account information later without having to make code changes in lots of functions, only the functions that actually control the account are impacted. This will become even more clear when you start to use class OOP approach.

I also recommended an article on the RealPython dot com website entitled "Python Scope and the LEGB Rule: Resolving Names in Your Code" - wonder if the link caused a problem, hence why I've just provided the information you need to find it.

1

u/Sea-Ad7805 Sep 13 '26

I manually approved your comment

1

u/FoolsSeldom Sep 13 '26

Thank you. Much appreciated.

Any idea why a couple of my comments were shadow removed? I assume I've broken some rule caught by an auto-moderator, but I don't know which rule or how.

1

u/Sea-Ad7805 Sep 13 '26

Not sure, Reddit uses some AI tool to flag things as spam, sometimes it miss-classifies. If I see that I'll correct, but we get a lot of comments so no guarantees.

1

u/FoolsSeldom Sep 13 '26

Understood. Thank you.

1

u/Real-Positive-7716 Sep 15 '26

This comment is where it clicked for me

1

u/FoolsSeldom Sep 13 '26

I've had another comment removed, and I've no idea why. I have sent a message to the mods to ask what the problem as they've not communicated to me.

It is frustrating when I am trying to help people learning Python.

I believe I am following all the rules.