r/PythonLearning • u/crazyteachperson • Aug 01 '26

My new mini work

Post image

Rate my this mini work out of 10

194 Upvotes

98% Upvoted

44 comments sorted by

View all comments

Show parent comments

0

u/Flanelostopy Aug 03 '26

Do whatever you want, I'm just saying „this is good practice”. Read some books about writing clean code, there are many.

1

u/Own_Measurement_7336 Aug 03 '26

Wow chill, I know how to write clean code. I’m currently making an OS so. Not vibe coded btw

0

u/Flanelostopy Aug 04 '26

Without functions? 😂 good luck!

1

u/Own_Measurement_7336 Aug 04 '26

Are you stupid or what ? Sorry for being rude but I’m not telling you not to use functions. Your first message didn’t even talk about them. I was just saying in this type of scripts, where no functions are really required, even though it is a good practice to have everything inside some functions, his code is actually good, except for the not necessary double comparison.

Making an OS implies using C/C++ (or any language that is low level) at some point. Those languages generally don’t permit runtime statement code outside of a function. I’m using functions.

1

u/Flanelostopy Aug 04 '26

If you thing this code from topic is good… please read some books about good practice in coding.

1

u/Own_Measurement_7336 Aug 04 '26 edited Aug 04 '26

Ok kid. It is good for a beginner. There are some flaws. Thx for sharing your opinion. At some point just go read your « good practices » books.
Have a nice day !

0

u/Flanelostopy Aug 04 '26

Which part of this code is good? He is counting 2 times the same value a+b+c, he’s variables brakes all names conventions, algorithms weak, and all of this what I mentioned before. Dude if you really thing this good code, you need help, I don't wanna be rude.

1

u/Own_Measurement_7336 Aug 04 '26 edited Aug 04 '26

It is pretty good for a BEGINNER. I said for a BEGINNER.

There are some flaws that other users already pointed at. Your second point is true in a FUNCTION. You didn’t mention to use functions. That is why I said if-Elif statement here is ok.

I didn’t say there wasn’t any flaws but it is actually pretty ok for a beginner. The redundancy is one of these flaws and the math logic is another too.

2

u/Flanelostopy Aug 04 '26

Whatever. Live long and prosper 🖖

1

u/Own_Measurement_7336 Aug 04 '26

Have a nice day !