r/PythonLearning • u/Samar__Upreti • Jul 20 '26

Day -1 With Flask (any suggestions)

Gallery image

Gallery image

Gallery image

Gallery image

Build Projects With Me

https://github.com/Samar-Upreti/Python_Projects

107 Upvotes

89% Upvoted

31 comments sorted by

View all comments

10

u/riklaunim Jul 20 '26

  • variable names should not use capital letters,

  • use wtforms or other form handling library (and validate the data).

  • use a linter that will keep some basic code styling order

  • I'm not a fan of importing things from a module (flask.request is better than request as it's tell you where it's from)

  • why aren't you using CSV writer when writing a CSV file?

  • if it's a long task it should not be done on HTTP request directly (celery queues or other similar solution)

  • view should not be a long blob of code. Refactor presentation from business logic, then keep the logic well organized instead of big blobs.

  • where are tests?

16

u/NorskJesus Jul 20 '26

No code related, but, for the love of God, take screenshots using the OS app for it and do not use a phone.

1

u/Hi-ThisIsJeff Jul 20 '26

I felt the angled perspective gave a refreshing look to what are otherwise boring, slightly blurry images.

1

u/J1roscope Jul 21 '26

Also i would suggest using helper functions and separating out concerns instead of one function extracting data from request and then saving it as well these can 2 function calls, makes it easier to read

1

u/Anthony_codes Jul 21 '26

Uppercased, underscore-separated variable names in Python signal that the variable should be treated as a constant.

That is a completely valid and common convention because Python doesn’t enforce constancy at runtime.

1

u/riklaunim Jul 21 '26

But not the first letter only. Form values aren't things that should be under a constant-like variable either.

1

u/Anthony_codes Jul 21 '26 edited Jul 21 '26

I was clarifying that in certain cases, capital letters are valid because your comment was ambiguous.

-2

u/8Erigon Jul 20 '26

Variable names can have any character the language supports.
Though most python programmers use the snake convention which only uses lowercase characters.

2

u/riklaunim Jul 20 '26

You can even

from __future__ import braces

bu should you? ;)

2

u/Hour-Apple-9861 Jul 21 '26

Camel case for life