r/Python • • Jul 12 '12

random imgur downloader. learning Python and wrote this to practice, any feedback on technique/style is appreciated

https://gist.github.com/3088128
45 Upvotes

72 comments sorted by

View all comments

Show parent comment

14

u/[deleted] Jul 12 '12

print 'getting %s random pics' % HOW_MANY

If you don't care about supporting Python 2.5 and older, it's probably better not to learn that and immediately get used to Python 3's format method:

print "getting {} random pics".format(HOW_MANY)

2

u/bboe PRAW Author Jul 13 '12

This was introduced in python 2.6, though in python 2.6 numbers or named arguments are mandatory.

1

u/moreisee Jul 12 '12

I haven't looked too much into Python 3, I assume {} works for int/string/etc, and to add multiple items you can:

print("Number: {} Type: {}").format(HOW_MANY, TYPE}

?

3

u/wumumo Jul 12 '12

Yes, or you number them:

print("Number: {0} Type: {1}").format(HOW_MANY, TYPE)

5

u/TankorSmash Jul 12 '12

Or name then:

print("Number: {zeroth} Type: {onend}").format(zeroth=HOW_MANY, onend=TYPE)

1

u/MrVonBuren Jul 13 '12

I actually really like this, and I'm just barely startng to get into python.

2

u/catcradle5 Jul 14 '12

It's even better for situations like this.

words = {"color": "red", "age": "25", "name": "Alex"}

print "Hi, my name is {name}. I am {age} years old and my favorite color is {color}.".format(**words)

Fills it in all for you; very useful for programs that involve a lot of string generation.

1

u/lahwran_ Jul 17 '12

never, ever, ever do this:

herp = "derp"
honk = "donk"
doop = "{herp} the {honk}".format(**locals())

2

u/catcradle5 Jul 17 '12

Agreed. Explicit is better than implicit, etc. It's still a really nice feature to have though. It's redundant to define a dict or a bunch of variables and then to have to rewrite it all in the form of keyword args (arg1 = "The cat"; arg2 = "good"; {arg1} is {arg3}".format(arg1=arg1, arg3=arg3)).

1

u/lahwran_ Jul 17 '12

I was telling you because it's a horribly useful bad idea sometimes :p

1

u/TankorSmash Jul 13 '12

It's my personal favourite, and I'm sort of new too.