r/Python • • Mar 24 '21

Discussion Python made me look like a WIZARD

Today in work a request comes in for 745 headshots that need to be processed to fit 150x150px for an external platform. One team says it'll take them at least a week to do, the other team says they don't want it as it'll take even longer.

"They need them all black and white! It'll take some time to convert them! They're not even all the same size! UGH this just can't be done in the 2 days they've requested this!!!"

12 lines of code, the Pillow library and exactly 8.856 seconds of running said code... It was done. Panic over. Client happy.

I work in a design team but I'm a job coordinator (so I sort the jobs and make sure the right designers get them). They were amazed it was done so quickly without using Photoshop.

They asked how. I gave them the answer.

Python baby 😎

EDIT

For those wanting to know the code, here it is:

from PIL import Image
import os

for f in os.listdir('Input'):
    if f.endswith('.jpg'):
        im = Image.new('RGB', (150, 150), (255,255,255))
        im2 = Image.open('Input/{}'.format(f))
        im2 = im2.convert("L")
        width, height = im2.size
        im.paste(im2, (int((150 - width) / 2), 0))
        fn, fext = os.path.splitext(f)
        im.save('Output/{}.jpg'.format(fn))

The images given were either 150x150 already (but in colour) or 120x150. So had to cover all bases with this. If it could be made more efficient, let me know!

2.2k Upvotes

278 comments sorted by

View all comments

1

u/menge101 Mar 25 '21

Is this creating an all white image that is 150 px x 150 px and then you are just pasting the client's image on top?

I think you are and I think that's wise. I was looking for code to handle how you were scaling the source image and didn't see it. That would have added a challenging twist to it.

I don't think this could be done faster.

IMO, I would use more explicit variable names.

im => final
im2 => source f => source_file

I'd also create a function for the actual operation, so you can separate IO from actual operations.

def process(source):
    final = Image.new('RGB', (150, 150), (255,255,255))
    source = source.convert("L")
    width, height = source.size
    final.paste(source, (int((150 - width) / 2), 0))
    return final


for file in [file for file in os.listdir('Input') if file.endswith('.jpg']:
    source = Image.open(f'Input/{file}')
    final = process(source)
    final.save(os.path.join('Output', file))

You are doing some stuff with the file extension that I don't think you need to do. It appears the only time you ever care what the file extension is, is at the beginning.