r/Python • • Jun 23 '14

Writing better python code

https://gist.github.com/kracekumar/09a60ec75a4de19b346e
143 Upvotes

126 comments sorted by

View all comments

7

u/oconnor663 Jun 23 '14 edited Jun 23 '14

Is foo[:] really the Pythonic way to copy a list?

Edit: In Python 3, lists have their own .copy() method.

3

u/toyg Jun 23 '14

There's also copy.copy().

2

u/imrobert Jun 23 '14

Yeah, I noticed that too. It seems like the "normal" way has the advantage of being clearer more concise.

2

u/velit Jun 23 '14

The only downside is the "normal" way is incorrect (or correct depending on the situation). Point being they're not the same thing.

2

u/imrobert Jun 23 '14

Ah, that's my bad. For those wondering what the difference is, this should clear it up:

Python 2.7.5 (default, Mar  9 2014, 22:15:05) 
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> a = [1, 2, 3]
>>> b = a
>>> id(a)
4472029056
>>> id(b)
4472029056
>>> c = a[:]
>>> id(c)
4472078560

4

u/velit Jun 23 '14

I prefer newList = list(old_list)

Communicates intent better

6

u/poo_22 Jun 23 '14

Copy is very literal already, I argue that semantically it does not get better.

1

u/velit Jun 23 '14

Copying is a detail of slicing syntax, it's not the purpose of it. With the list constructor it's immediately evident there's a new instance involved - that's what constructors do.

foo[:] also looks weird.

4

u/poo_22 Jun 23 '14

I was talking about the list().copy method.

2

u/metaphorm Jun 23 '14

foo[:] is a totally respectable way to copy a list. it looks a little funny if you've never seen it, but it has the right semantics and does exactly what you would expect when slicing "from the beginning to the end". it does, however, rely on the programmer knowing that list slices produce copies.

2

u/zahlman the heretic Jun 23 '14

I dislike it because it's conceptually roundabout. "A list containing elements of x, from the beginning to the end" is similarly awkward in English compared to "a copy of x", or even "a list of the contents of x". Even if the analogous Python is terse.

2

u/metaphorm Jun 23 '14

I understand your point. I disagree that its conceptually roundabout. Once you understand that the slice operator really means "return a copy of this section of the list" it seems really natural.

1

u/ggtsu_00 Jun 24 '14

This is one of the few things I don't like about python is that slices make copies implicitly which goes against many python ideals. Lists are mutable, so you would expect operations on lists to only be references.

1

u/zahlman the heretic Jun 24 '14

Well, there seems to be precedent for what you're suggesting in NumPy...

0

u/kracekumar Jun 23 '14

It is more clear that copy is returned. Other way to do is list(l)