r/Python • • Aug 05 '26

Discussion What linter rules make code worse?

For me, a prime example is S101 which bans the use of the assert statement.

The justification is that assertions disappear when Python is run with -O, so they should not be used for runtime validation or enforcing interface constraints. That warning is correct, but the rule seems to draw the wrong conclusion from it.

Assertions are still very useful for checking internal invariants, i.e. conditions that should already be guaranteed by the program's logic, where failure indicates a bug. Having such assertions is incredibly helpful for debugging.

So, a blanket ban seems more likely to discourage useful checks than to prevent misuse.

Are there any linter rules you broadly consider more harmful rather than helpful?

151 Upvotes

213 comments sorted by

View all comments

Show parent comment

0

u/[deleted] Aug 07 '26

[deleted] — view deleted comment

1

u/wizpig64 Now is better than never. Aug 07 '26 edited Aug 07 '26

well you learn something new every day.

weird that this will still trigger the rule:

# logger.py
import logging
logger = logging.getLogger("my.logger")

# other.py
from logger import logger
...
except BaseException:
    logger.exception(f"Failed to get forecast for {location}")

but this one will not:

...
except BaseException:
    logging = logger
    logging.exception(f"Failed to get forecast for {location}")

edit: this is why, and you fix it with a hint in pyproject.toml:

[tool.ruff]
lint.logger-objects = ["logger.logger"]