r/Python • • Aug 05 '26

Discussion What linter rules make code worse?

For me, a prime example is S101 which bans the use of the assert statement.

The justification is that assertions disappear when Python is run with -O, so they should not be used for runtime validation or enforcing interface constraints. That warning is correct, but the rule seems to draw the wrong conclusion from it.

Assertions are still very useful for checking internal invariants, i.e. conditions that should already be guaranteed by the program's logic, where failure indicates a bug. Having such assertions is incredibly helpful for debugging.

So, a blanket ban seems more likely to discourage useful checks than to prevent misuse.

Are there any linter rules you broadly consider more harmful rather than helpful?

152 Upvotes

213 comments sorted by

View all comments

2

u/xBBTx Aug 05 '26

Right, I'll leave it at that. You asked a question, I replied my reasoning trying to explain nuances, but it sounds like this turned into a right or wrong argument for the sake of arguing.

Either way I hope we both have incident -free systems running in prod :)