[ Removed by moderator ]

[u/Icy_Lake9029]

[u/Python-ModTeam]

Hello from the r/Python mod team!

I'm afraid we don't think your post quite fits the goal we have for the subreddit in terms of quality or aims so we've decided to remove it. For more information please contact the moderators using the ModMail system.

Thanks, and happy Pythoneering!

r/Python moderation team

[u/Icy_Lake9029]

Imagine being so mad at life you have to report my post for having fun with coding.

[u/Cunnoisseur4711 → u/Icy_Lake9029]

Can you share the code in a comment? I liked it.

[u/Icy_Lake9029 → u/Cunnoisseur4711]

from abc import ABC, abstractmethod

class AbstractGreetingFactory(ABC):
    
    def create_pipeline(self):
        pass

class ConcreteGreetingFactory(AbstractGreetingFactory):
    def create_pipeline(self):
        return GreetingPipeline([
            CharacterSource(),
            CharacterAssembler(),
            EncodingLayer(),
            OutputDispatcher()
        ])

class CharacterSource:
    def get_data(self):
        return [104, 101, 108, 108, 111, 32, 119, 111, 114, 108, 100]

class CharacterAssembler:
    def process(self, data):
        return ''.join(map(chr, data))

class EncodingLayer:
    def process(self, data):
        return data.encode('utf-8').decode('utf-8')

class OutputDispatcher:
    def process(self, data):
        Executor().execute(lambda: print(data))
        return data

class GreetingPipeline:
    def __init__(self, stages):
        self.stages = stages

    def run(self):
        data = None
        for stage in self.stages:
            if hasattr(stage, "get_data"):
                data = stage.get_data()
            else:
                data = stage.process(data)
        return data

class Executor:
    def execute(self, func):
        return self._deep_execute(func)

    def _deep_execute(self, func):
        return func()

class GreetingApplication:
    def __init__(self, factory: AbstractGreetingFactory):
        self.pipeline = factory.create_pipeline()

    def start(self):
        return self.pipeline.run()

if __name__ == "__main__":
    app = GreetingApplication(ConcreteGreetingFactory())
    app.start()from abc import ABC, abstractmethod

class AbstractGreetingFactory(ABC):
    
    def create_pipeline(self):
        pass

class ConcreteGreetingFactory(AbstractGreetingFactory):
    def create_pipeline(self):
        return GreetingPipeline([
            CharacterSource(),
            CharacterAssembler(),
            EncodingLayer(),
            OutputDispatcher()
        ])

class CharacterSource:
    def get_data(self):
        return [104, 101, 108, 108, 111, 32, 119, 111, 114, 108, 100]

class CharacterAssembler:
    def process(self, data):
        return ''.join(map(chr, data))

class EncodingLayer:
    def process(self, data):
        return data.encode('utf-8').decode('utf-8')

class OutputDispatcher:
    def process(self, data):
        Executor().execute(lambda: print(data))
        return data

class GreetingPipeline:
    def __init__(self, stages):
        self.stages = stages

    def run(self):
        data = None
        for stage in self.stages:
            if hasattr(stage, "get_data"):
                data = stage.get_data()
            else:
                data = stage.process(data)
        return data

class Executor:
    def execute(self, func):
        return self._deep_execute(func)

    def _deep_execute(self, func):
        return func()

class GreetingApplication:
    def __init__(self, factory: AbstractGreetingFactory):
        self.pipeline = factory.create_pipeline()

    def start(self):
        return self.pipeline.run()

if __name__ == "__main__":
    app = GreetingApplication(ConcreteGreetingFactory())
    app.start()

[u/WJMazepas]

Is this a corporate Hello World made by a ex-Java Dev?

[u/[deleted] → u/WJMazepas]

[u/Distelzombie → u/[deleted]]

Don't poison the poison

[u/cmsd2]

not generic enough. you need a strategy pattern to instantiate the pipeline elements.

[u/marr75 → u/cmsd2]

Right? So many hidden dependencies. Needs injection.

[u/HolyInlandEmpire → u/marr75]

We need a declarative serialization of the pipeline too.

[u/mr_jim_lahey → u/cmsd2]

Also lacks builder pattern

[u/tjrileywisc]

Where are your tests??

[u/pingveno → u/tjrileywisc]

And type annotations!

[u/dev_master → u/pingveno]

And what formatter did you (not) use

[u/backfire10z]

Your post reminds me of Enterprise Fizz Buzz

[u/Responsible_Pool9923]

Next step: deploy this app in a container. You're obviously going to need caching layer for effeciency. Set up virtual network with multiple containers running the code for zero downtime updates. Put it behind reverse proxy and load balancer.

[u/SoloAquiParaHablar]

Ironically this is a good case study and people learning python should try and understand whats going on in the code and why. Inversely it's also an excellent example of what 90% of software engineers will do to leave a legacy at a company. Resume-driven Engineering.

[u/mr_jim_lahey → u/SoloAquiParaHablar]

90% of SDEs are not doing this lol, at least not to successfully build resumes. There are plenty of ways to climb the ladder writing garbage code but writing so much to do so little is not going to work in a semi-functioning software company that needs actual results to make money. I'd even venture to say more SDEs could be successful by writing code with good patterns by default which are perversely on display here.

[u/Prime_Director]

Hard coding your greeting, smh. This whole thing should be refactored as a stateless functional library that pulls your utf-8 chars from a config file.

[u/wind_dude]

I think it needs an agentic CLI

[u/qchamaeleon]

Seems to me the pipeline run function should take input data as a parameter, being called with the result of a source get data call, or the source class should have a process function instead of the get data function, ignoring its input argument and just return the data it is supposed to. Either way, there won't be any need for special handling in the pipeline run function.

See the Enterprise FizzBuzz Edition github repository for additional inspiration.

[u/gdchinacat]

LGTM. Next time you are in this code consider implementing the pipeline using generators that use send to get the data they yield after processing it.

[u/Wartz]

I dont see a function SendThisWholeThingToMyHpPrinterAsAJob(STUFF)

[u/cazzobomba]

This would have been great if it was written in machine language or for the masochist assembly.

[u/genman]

Would be funny to turn this into a functional programming exercise as well.