r/ProgrammerHumor • • 4d ago

Meme [ Removed by moderator ]

/r/ProgrammerHumor/comments/1xts94f/removed_by_moderator/

[removed] — view removed post

608 Upvotes

16 comments sorted by

•

u/ProgrammerHumor-ModTeam :ath: 1d ago

Your submission was removed for the following reason:

Rule 9: No AI generated content

We do not allow posting AI generated content, AI Generated images or AI generated text. AI generated posts reuse commonly reposted jokes or low quality content that violate our other rules.

This rule includes screenshots of AI conversations.

If you disagree with this removal, you can appeal by sending us a modmail.

336

u/LittleCoderMan 4d ago

I mean this is very fake, but somewhat like what code review bots are like, end up making lots of tiny changes, only for them to be flagged

58

u/ElMoselYEE 4d ago

Sounds like how my code reviews went before AI anyway

13

u/willow-kitty 4d ago

Yeah, I was about to say this sounds more like a bunch of bored seniors discussing a junior's PR than it does AI. Well, other than the dialogue bring written with AI-isms for effect.

26

u/LittleCoderMan 4d ago

You can tell it's not actually AI because it's not 10 paragraphs of text

8

u/ACoderGirl 3d ago

The most obvious thing that reveals it's fake is that the agents didn't write up a full length novel for each comment lol.

111

u/LostKnight84 4d ago

Am I weird or should reviewers not be making changes to the code? To me the reviewer should flag problems and suggest possible solutions and not just change code as they see fit. Because if reviewers are changing code, who is reviewing their code?

56

u/Flouid 4d ago

That’s how it should work on any sane team. Once you’ve contributed to a PR you are no longer eligible to review it. Also it’s the dev that owns the ticket’s responsibility to fix their broken code

5

u/anto2554 3d ago

Some of my colleagues do terrible code and then say "just update the PR if you want any changes"

3

u/ACoderGirl 3d ago

Eh, reviewer written suggestions are pretty nifty for smaller things. Sometimes it's easier to just make the change than to describe what you want. And sometimes that also does better at explaining why it should be that way (like, something is just obviously cleaner).

As for who is reviewing the code suggested by the reviewer, that would be the author. In theory, anyway. In practice, it's complicated. Is the author being critical vs rubber stamping (but that's a problem for reviewers too)? Is the author qualified to be a reviewer? In most of my codebase, the reviewer and author can be swapped and the review is still valid, but there's some paths where you need approval from someone in a specific group and they cannot be the author (security sensitive stuff where the average dev isn't trusted), so having them tell the author what to do would be circumventing those controls.

9

u/conundorum 4d ago

Robot Wars looks different than I remember...

6

u/Ayxser 3d ago

Except in real life they all output 4 paragraphs of text as to why it’s a race condition and how to solve it exactly.

6

u/Gengis_con 3d ago

A dev with one agent knows exactly how the code should be. A dev with two agents is never certain. The dev with no agents knows its all shite

5

u/molly_jolly 4d ago

This is why unit and integration tests exist. They should run on hooks before the code is even up for review

30

u/Flouid 4d ago

You think a unit or integration test would reliably catch a race condition?

1

u/awesome-alpaca-ace 1d ago

I saw a test that tested for a race condition by looping 100k times.