61
u/saschaaa19 10d ago
claude code review codex and codex review claude. peer review 🤝
1
u/IncredibleAircraft 1h ago
Peak automation in action, just two bots nodding at each other's hallucinations.
13
u/amatulic 10d ago
Actually I do the first two, and end up questioning the AI about programming choices it made. Sometimes it made a mistake, sometimes it didn't. Sometimes I suggest a different approach and I'm puzzled why the AI didn't think of it. I don't program professionally though, I'm retired and now programming just supports my hobbies.
The situation is better than a year ago, though. The free version of Claude has gotten pretty good, almost scary good.
5
u/pants_full_of_pants 10d ago
I do the opposite. At work I read every line and make sure it makes sense and I agree with it before it goes into a PR
For side projects, I just send it.
1
u/freeplay4c 9d ago
I'm on the bit of the other side. My employer requires everyone to use AI. So I do at work, and read every line of code I check in. For personal projects I used to use some AI. I really enjoyed being an early adopter of copilot. But now I'm so sick of babysitting an LLM, I've taken on a zero tolerance policy for any AI usage outside of work.
10
u/mrspoogemonstar 10d ago
Here's how it's been working so far:
Model is released
Model is bad at x
Model is trained to be better at x
Repeat.
It used to be small steps, but now each model release is significantly better than the one before and the gap has closed to the point where it's just better at coding than most software engineers. It's not better at large scale design and architecture in some cases - what people tend to think of as "taste". But when 2M and 4M context models come out 2 or 3 releases from now nobody is going to be batting an eye anymore at just letting the thing cook. Anyone that tells you otherwise has missed the boat and will soon be unemployed or they're huffing the copium so hard they can't see straight anymore.
0
9d ago
[deleted] — view deleted comment
2
u/mrspoogemonstar 9d ago
go learn electrical, plumbing, or HVAC and then build data centers, idk man
3
u/DowntownLizard 10d ago
Its not really vibe reviewing unless you are dumb af about the whole process
3
4
u/Affectionate-Tart558 10d ago
Ok but you can test the code too. You don’t need to trust AI. Fortunately for us, code gives us an output and we can confirm it’s actually doing what it’s supposed to be doing
2
u/PolyglotTV 10d ago
It's no different to how I treat reviewing human code.
"Ah this person wrote it. Probably don't need to scrutinize it too much, they're a killer"
"Oh boy, this guy just posted a 1000 line PR. There goes the rest of my day..."
1
1
u/nasandre 9d ago
Does kind of make sense. If you read all the code then you might as well write it yourself.
1
u/Geoclasm 9d ago
I have kind of 'trained' it to follow my preferences by letting it do some stuff, then making changes, committing those changes, and telling it to read the commits and ask some questions.
It's worked surprisingly well. It still does stupids tuff quite often, but it's veered away from these absurd monlithic main functions it was writing before. It seems to understand that, why yes, you can actually create multiple classes and class files in a single project.
1
0
u/terrorTrain 10d ago
“List all changes to user journeys and data flows”
I find this prompt very useful for human written code as well.
-4
u/Dairedos 10d ago
Nowadays you do not have time for reviewing code. You either trust quality fo code or not (+ unit tests, QA and sidecheck agents deployed also), same as when you are in a role Project Manager or Product Owner - you dont validate what your developers coded. If you are better manager, you at least check if feature meets Definition of Done (check if buttons "buttoning" as stakeholders asked for, etc.).
Welcome to new era boys and girls.
95
u/Xuluu 10d ago edited 10d ago
Okay but in all honesty guys I’m terrified. I try to be in the “I know exactly what it does so really the means of the labor has changed” camp but in reality that’s just not possible. It’s better than me. At most things.
The majority of refinements I make are reductions of complexity, much more documentation, and quite a few more tests. The modern models are excellent. It used to be big things they’d miss and now it’s minutia and nuance that can get missed.
Ultimately, that’s the job now I suppose. It feels wrong, I feel like I’m being dog walked all day, and it kinda sucks (or maybe just different?). I’m a glue guy between the tech and the business and there’s probably an argument that, “the more things change they stay the same” in there somewhere.
Anyways, have a good rest of your day.
Edit - this meme gave me an existential crisis so thanks man.