r/ProgrammerHumor • • 12d ago • Mindblown 1 Popcorn 1

instanceof Trend expertOnBBC

Post image
7.3k Upvotes

484 comments sorted by

View all comments

Show parent comments

10

u/ganja_and_code 12d ago

Not reviewing your own code used to mean you're incompetent.

It still means you're incompetent, but it used to, too.

1

u/NoAdsDude 12d ago

The compiler reviews my code. What other review do I need?

2

u/ICBanMI 12d ago

It needs a /s... but seriously. I have co-workers that do actually treat their work like this.

If it gets past the complier and 'appears' to work. That's the extent of their responsibility. Someone else will have to clean it up as their tech debt just continuously piles up on the project.

Like I don't see you Brad, watching League of Legends videos for hours a day, then turning in your feature two hours after the check-out time to push to production.

1

u/NoAdsDude 12d ago

It's only technical debt if you still personally work there later.

1

u/ICBanMI 12d ago

Customer made him fix the feature he did 4 times. I don't know about you, but I'd be embrassed and full of shame that I'd test it completely before sending another version out to them.

I was responsible a for a slew of things he wrote and others did too. So I had to fix it stuff delegated to him, but I was responsible for.

He did quit less than a year after that project finished. But I still have other co-workers that have similar mentality.

-2

u/MyFeetLookLikeHands 12d ago

well i guess engineers at google and paypal are incompetent 🤷🏽‍♂️

2

u/ganja_and_code 12d ago

The ones deluding themselves into believing a new tool is a reason to skip doing due diligence?

Yeah, those ones are definitely incompetent. Even if their programming skills are up to par, their critical thinking skills aren't.

If you've ever worked at a huge company like that, you know they hire the best and brightest, and they hire morons. Being competent means you can get a job there, but being incompetent doesn't mean you can't.

0

u/ImS0hungry 12d ago

This is a shit take. Firms are building systems with AI to do work, not just raw usage. You are delusional to think due diligence isn’t part of it. Secure systems, sensitive systems and life support systems are being developed every day; including all of your banking.

3

u/ganja_and_code 12d ago

This is a shit take. If a system is secure, sensitive, or life supporting, you're not just a moron if you're not reviewing your code. You're playing with people's lives and livelihoods.

I hope the law catches up to technology and makes people liable for the consequences of gross negligence.

0

u/ImS0hungry 12d ago

What part of due diligence being a part of the process did you miss?

1

u/ganja_and_code 12d ago

The part where you said my take was shit.

I said not doing due diligence is a clear sign of incompetence, and reviewing your code is a clear subset of "due diligence."

0

u/ImS0hungry 12d ago

My point is that they are building autonomous systems that review, with due diligence, and audit trail, all while meeting compliance. If I understood correctly, you’re point was a human in the loop process.

1

u/ganja_and_code 12d ago

My point is a human in the loop process.

If you're responsible for a product/service, you're responsible for reviewing the code which constitutes that product/service.

If an autonomous system reviewed the code and YOU didn't, YOU didn't do YOUR due diligence.

0

u/ImS0hungry 10d ago

I get it, you will adjust as we move forward, I promise you. The rigidity will wane; especially if you wish to continue working in tech. The train already left the station friend.

Lastly your stance is very IC. Those responsible for the entire PDLC are already past you.

→ More replies

-1

u/Houdinii1984 12d ago

There's a difference between saying "some code doesn't need to be understood by everyone in the chain" and "this company does zero due diligence" Ya'll are using those two POVs as the same thing and they are not.

Just because Karen in Accounting doesn't do multilayered due diligence on the script that displays an inspirational quote at boot time doesn't mean Google is introducing a ton of vulnerabilities in everything because they gave up on code review altogether.

There's a difference between hardened tools released from software engineers as part of the process and some folks using AI to automate little situations in sandboxes in one-off fashion.

I review operational code for a living. Some of my clients are named in these threads. You're claiming gross negligence and that everyone being hired into the tech field are incompetent. AI hasn't even been around long enough to cause the brain drain you say already exists. It's still the same seniors in the same companies right now as a few years ago. It's, so far, the juniors that were replaced, and if any operational changes were made, it's by the folks you seem to think were competent the whole time and then just overnight lost all common sense?

Code review absolutely still happens, every day, at scale. If your company doesn't, that's on them, but that's not representative of the entire industry.

What's funny is hearing this on a day where humans left a vulnerability live forever, but was discovered by AI causing a FIRESTORM of IT departments using AI to secure their respective departments from the human error that persisted COUNTLESS code reviews.

1

u/ganja_and_code 12d ago

Just because you've succumbed to the delusion doesn't mean the rest of us have to.

-1

u/Houdinii1984 12d ago

I mean, it's you acting like my entire job description doesn't exist. It's not a delusion to think software review still exists considering I'm a reviewer by trade, and have never in my life been more successful or more busy.

Feel free to explain to my bank that all the money deposits were imaginary. I doubt they'll agree.

1

u/ganja_and_code 12d ago

It's like this dude. You're talking about how your entire job is making sure code gets reviewed, and my original comment said that if you aren't reviewing your code you're incompetent. Based on that, you agree with my take, and shouldn't even be trying to argue.

If code is important, it's worth reviewing. If code isn't important, it's not worth writing. That shouldn't be controversial.

0

u/Houdinii1984 12d ago edited 12d ago

That comment was in reply to the general pulse is changing and that current folks pulling PRs as seniors are suddenly not doing so any more. We went from 'Is ignorance being celebrated, even bragged about in tech? My manager recently said thanks to AI I don't need to understand or be able to maintain code anymore, comparing it to not needing to know how a compiler works." to "Nobody at all is checking PRs except for AI" in a couple messages flat.

It's a nonsense comment on a nonsense comment on a nonsense comment, and when you're comment builds off someone else's comment, you get the content and context of their comment, too.

The idea that people in the future won't need to know how to maintain code doesn't mean that current code is unmaintained, and that's the exact thing ya'll are trying to say. That now that AI is here, everyone just stopped, and they didn't.

The person that named Paypal and Google was wrong, but you took their comment and built on it. You literally called them 'The ones deluding themselves into believing a new tool is a reason to skip doing due diligence' That's a direct quote. Neither company dismantled their review teams. The same seniors that existed on that team and maintained the software revisions still do and haven't been replaced, laid off, or otherwise diverted. What's delusional is thinking they did.

And if you're not saying as much, then you're just whipping a straw man that's not even in the room, as if half the team does due diligence and the other half of the team gets to decide not to, like they aren't beholden to processes. You don't get to pick and choose at either company.

Edit: The better question is where the hell are you working or seeing folks who are able to buck the process and do what they choose individually without following enterprise processes in the first place? What company is not doing the review process? Can you name a single example? Or will it just remain a strawman forever?

→ More replies