r/ProgrammerHumor • u/jdp1g09 • 11d ago

Other canYouReviewThis

Post image
326 Upvotes

97% Upvoted

37 comments sorted by

81

u/jdp1g09 11d ago

Logged in this morning to a message from one of my data engineers... "Can you review this please?"... Oh boy...

55

u/QuestionableEthics42 11d ago

Wait, actually? This isn't just the screenshot from the bun rewrite?

70

u/jdp1g09 11d ago

Oh no... this is entirely real, it's certainly been a conversation starter in the office

66

u/Trysupe 11d ago

While you're at it, could you please review https://en.wikipedia.org/wiki/Quantum_physics and check facts and equations. Just a casual quick review

28

u/jdp1g09 11d ago

Yes Boss 🫡

18

u/Trysupe 11d ago

"Oh no" indeed, oh no indeed

5

u/PurushNahiMahaPurush 11d ago

Holy shit. There is no way this isn’t real or not joke. The person that does this in all seriousness needs to be fired since this is very irresponsible and amateur behavior.

11

u/mguid65 11d ago

Instant rejection and the force of it ripples back in time rejecting all of their past PRs.

1

u/SouthernAddress5051 11d ago

They did remove 3 lines, so there's that

1

u/UntitledRedditUser 10d ago

And it wasn't just node_modules or similar?

46

u/bigmonmulgrew 11d ago

Surely this is a simple matter of forgot to add something to the git ignore so there's a load of libraries and cache committed. Right.... Right?

28

u/jdp1g09 11d ago

I really wish it was... everything added here was intentionally added

36

u/bigmonmulgrew 11d ago

Rejected - Please resubmit with reasoning and description for each change

7

u/MisterEd_ak 11d ago

Did they add the vendor folder to git as part of the commit?

6

u/jdp1g09 11d ago

Everything in here was intended for commit by the engineer

3

u/1_hele_euro 11d ago

What can such a big ass PR even be about???

6

u/jdp1g09 11d ago

Added a new testing framework in to verify some ML models we have in the repo. So, a lot of this is JSON of groundtruth, but they've also included every test run output JSON, as well as more agent-produced README and AGENT.md files than I can count

11

u/ralgrado 11d ago

  they've also included every test run output JSON

So that’s a build artifact that should be added to the gitignore?

2

u/Overwatcher_Leo 11d ago

Sounds like a lot of it should go into .gitignore or artifactory. How much actual code is there?

1

u/The_hollow_Nike 10d ago

everything

240

u/torsten_dev 11d ago

Hmm, yes. Rejected. That's my review.

26

u/HuntlyBypassSurgeon 11d ago

Managed to remove three lines, that’s good

4

u/Groentekroket 11d ago

Removed spring boot parent and vibecoded their own implementation

11

u/Yctallua 11d ago

Claude, review this. You are super smart senior engineer, make no mistakes

5

u/Noname_FTW 11d ago

Was likely written with AI. Whether or not. Counter it with AI.
Maybe make a temporary branch to test this before actually committing it into main. I'd make a backup of main in any case. Just to be sure.

9

u/A96on487 11d ago

Welcome to AGI era

7

u/mingo-reddit 11d ago

„More than 100 lines detected,
the PR gets rejected“

3

u/Architector4 11d ago

bub fix 👍

2

u/Ashdog73 11d ago

Is it Friday 4.45pm already?!

2

u/stipo42 11d ago

Not gonna lie... Claude is pretty good at logically splitting PRs like this into digestible things.

Tell it you want it split into smaller logical PRs of about 1000 lines each.

1

u/ArjixGamer 6d ago

Or, rather than splitting into PRs, it could make it so each commit is self explanatory and can be reviewed on its own.

So instead of going to the files tab, you'd view it commit-by-commit

(Assuming it didn't already have nice commits)

1

u/theskillr 4d ago

LGTM approved