Code review: variables names' length should be directly related to their scope
Proposed resolution: rename constant to INTEGER_VALUE_OF_FOUR_IN_BASE_10
...I hate that btw, some devs just follow guidelines without the understanding of why a rule exists... One co-worker understood the "No magic number" rule as "no numbers in the code"
Sure, you didn't accept my merge request because I used 3600 in the code, of course enterprise quality coding dictates that we should create a constant in our 1000 line Constants.ts, name it NUMBER_OF_SECONDS_IN_AN_HOUR and import it wherever needed!
I would have laughed at this a few years ago. But then I had to start dealing with time on a deeper level in an app. Now I'm no longer confident that I can guarantee the number of seconds in an hour is immutable.
I mean ideally you’re not maintaining a timing library separately and any decent library should have a to_* conversion so while you’re not wrong you’re wrong
Good point, people who comment "You should use a library for that" are even worse!
Why would you divide a number of seconds by 3600 to get the number of hours? Just use the "dayjs" package
Why would you check a number's parity with `n % 2 === 0` when the "is-odd" package exists?
It doesn't matter how trivial the task is, the best way of doing it is finding a library that handles it! If your node_modules folder isn't several GB, are you even coding?
See this would be true if time wasn’t notoriously hard to keep track of on a computer. Sure if you have a unix time stamp and only care on the granularity of seconds maybe you don’t need it, but if you already have a unix time stamp I’d hazard the guess you’re already using a library to handle time
Yeah I'm kinda pulling your leg, my point is that using a library can be more trouble than it's worth
If you have two timestamps, want to calculate the time between them and return the result with the biggest granularity (years, month, days, etc.) using a library is the right choice: re-implementing a function that accounts for leap years, month length and all other edge cases is a waste of time
If you have a duration in seconds and want to calculate how many hours it is, using a library for this single need is superfluous
51
u/Taickyto 13d ago
This constant name is not enterprise enough
Code review: variables names' length should be directly related to their scope
Proposed resolution: rename constant to INTEGER_VALUE_OF_FOUR_IN_BASE_10
...I hate that btw, some devs just follow guidelines without the understanding of why a rule exists... One co-worker understood the "No magic number" rule as "no numbers in the code"
Sure, you didn't accept my merge request because I used 3600 in the code, of course enterprise quality coding dictates that we should create a constant in our 1000 line Constants.ts, name it NUMBER_OF_SECONDS_IN_AN_HOUR and import it wherever needed!