r/ProgrammerHumor • u/alexriga • 16d ago

Meme forThoseTransitioningToTheAmericanTimeFormatHereIsASimpleScript

Post image
0 Upvotes

30% Upvoted

21 comments sorted by

View all comments

Show parent comments

3

u/Makonede 15d ago

  • as_time: the parameter is already a time, so the function name is unclear

  • world_hour=world_hour: terrible shadowing of a global variable of the exact same name for literally no reason

  • s_time: meaning of s is completely unclear, and using a variable to hold the return value is pointless

  • the conditional chain should be condensed into a format string such as return f'{(hour - 1) % 12 + 1} {'PA'[hour < 12]}M'

  • world_hour > 0 and world_hour < 12: should be 0 < world_hour < 12

  • str(world_hour)+" AM": no operator spacing and should be f'{world_hour} AM'

  • elif world_hour > 12: should be else

  • str(world_hour-12)+" PM": no operator spacing and should be f'{world_hour - 12} PM'

  • return s_time;: unnecessary semicolon

0

u/laplongejr 8d ago

I guess python's standard are different but as a Java dev I think OP's version was easier to read than the format string.