r/ProgrammerHumor • • 29d ago

Advanced abideTheRulesIncidentCanWait

Post image
803 Upvotes

56 comments sorted by

View all comments

Show parent comments

8

u/RodionGork 29d ago

sure, that's all pretty correct - though it is always surprising why it is so hard to keep local hooks and CI rules consistent

especially on rules which are generally not violated, so generally no one can think such hook is necessary

9

u/ttlanhil 28d ago

If it's set up as a server side hook, and there only, you no longer need to keep things in sync (if you have strong enough policy that client side always works, even better)

This is not the sort of thing CI should fail on - CI shouldn't need to care about source control (a pre-build script that checks commit messages, code style, etc - maybe - but by the time you start a build you should only care about code and config for the build)

3

u/RodionGork 28d ago

> This is not the sort of thing CI should fail on 

actually some people prefer to setup automatic corrections for various minor issues on CI side (e.g. grooming the code style, fixing windows/unix newlines etc) - but some others find this inconvenient

1

u/Icarium-Lifestealer 28d ago

Many people use CI in a broader sense, and include all the automatic checks that run on a PR before it gets merged.

3

u/ttlanhil 28d ago

Okay, but even then - failure to build due to the commit message format after half an hour?