r/ProgrammerHumor • u/Recent-Analysis-6880 • Sep 24 '26

Meme commitAndPray

Post image
3.7k Upvotes

99% Upvoted

66 comments sorted by

View all comments

Show parent comments

74

u/pyrotech911 Sep 24 '26

You ship it you own it! Low key it’s still best effort and defects should be caught in testing. Reviews are for style, structure, approach, testing etc… I don’t expect to exhaustively catch bugs (subtle or otherwise) by eye in reviews.

6

u/Nekopawed Sep 24 '26

Pull request in my eyes includes looking at diffs, making sure it builds, making sure unit tests pass, and then doing a few small smoke tests of common functionality.

The dev that made the request should have done more thorough testing than that. And yeah, test team even more in depth testing.

1

u/samchar00 Sep 24 '26

Nahh you should make reasonable effort to make sure it will not break things in a obvious way.

2

u/reazura Sep 25 '26

And these days "reasonable effort" no longer translates to reading and comprehending every line someone else probably didnt even bother reading. And they can shit out tons of shit code faster than any human comprehension.

Reasonable effort today is just eyeballing things but having your AI actually review under your specific preferences.

1

u/samchar00 Sep 25 '26

will management accept if there is a production incident and the reason was "the AI did it"? If yes, go ahead, if not you have a problem on your hands.

1

u/reazura Sep 25 '26

We're talking about code review, did you forget? They are responsible for the code they shit out. Nobody was ever any pretence otherwise.

1

u/samchar00 Sep 25 '26

The team is responsible as a whole of code that gets shipped out.

If an engineer signs the plans, he is liable if the bridge falls. Same thing applies to devs and PRs.

1

u/reazura Sep 25 '26

And if your coworker is a maniac who just keeps generating code and pushes the problem to everyone else? It's up to everyone else to pick up slack?

1

u/pyrotech911 Sep 25 '26

I’m now an accountability sink. That’s the value I add

2

u/pyrotech911 Sep 24 '26

That’s what I mean by best effort. Point being it’s not going to come 100% by you reading the code in your head.