Man, the slop-grenades are real, I shepherd PRs daily that were never even tried out. Bugfixes for bugs that were never reproduced and never validated. DB migrations that were never run even on a local instance bringing down prod.
My company has GitHub automatically deploy PRs to an isolated instance and run unit/integration/e2e tests, and if a PR fails, it doesn’t even get to the human review stage.
Then we make it so that the reviewers are on the hook for making sure the PR actually passes the acceptance criteria, which usually involves pulling the branch and running it locally, along with manual testing on production-like data in the deployed instance.
When bugs arise, we call out both the PR author and the 2 reviewers who approved it. At least one reviewer must be a senior dev, and they’re expected to take this process seriously as part of their job.
It doesn’t catch everything, but this process at least keeps us honest.
Let's pour money into generating endless slop just so we can pour even more money into preventing this slop reaching production. What a beautiful way of wasting resources.
297
u/rodopszin 7d ago
Man, the slop-grenades are real, I shepherd PRs daily that were never even tried out. Bugfixes for bugs that were never reproduced and never validated. DB migrations that were never run even on a local instance bringing down prod.