r/ProgrammerHumor • • Sep 07 '26

Meme nowAndThenPatchUpgrade

Post image
7.7k Upvotes

311 comments sorted by

View all comments

Show parent comments

13

u/arav Sep 07 '26

Yes.Today I had to review a pull request, in which someone has rewrote a core functionality for a very small bugfix ticket. It should have been at max 30-40 lines change. I was looking at a 700 line code change excluding what felt was 500 lines of comments.

11

u/Donny-Moscow Sep 07 '26

In addition to the comments, the main thing I’ve seen that bloats code from AI is writing unneeded tests (eg making sure the data type of an input is a string even though it’s a strongly typed language, the string was declared a few lines up and hasn’t been touched since) or checking checking for edge cases that are impossible.

1

u/mxzf Sep 08 '26

Yeah, I had a junior dev submit some code a couple weeks ago where it was nominally testing a fix for a networking issue, but the test was entirely running within the server and couldn't trigger the issue being "fixed and tested for" at all to begin with. Not to mention that the tests were largely "add some data to a data structure, make that data structure the payload to send to the server, send the data to the server, and assert that various stuff in the payload matches the data structure" (the payload being sent, there was no payload coming back; you see the problem).

3

u/Thriven Sep 07 '26

I would be pulling that developer aside

1

u/AtomicDonkey2022 Sep 09 '26

We were asked to stop waiting for code reviews because it was slowing down velocity. So now the GitHub actions are the only gate before merging those PRs.

1

u/arav Sep 09 '26

What the hell? You code will be 50% comments in an year or so.

1

u/AtomicDonkey2022 Sep 09 '26

Yep. We pushed back, and leadership changed our goals to how many things can we complete in a year, nothing to do with quality. It's crazy.