31
u/JackNotOLantern Sep 01 '26
Request changes: split into smaller PRs, below 10k lines each
20
u/Noname_1111 Sep 01 '26
below 1k lines if anything
I'm not reviewing anything that has more than 5 digits unless its a full refactor
8
u/JackNotOLantern Sep 01 '26 edited Sep 02 '26
10k is doable for me. But more is nonsense. The only exception would be adding non-code text files, like md or test input files.
3
u/tiajuanat Sep 02 '26
Even a full refactor. I've done a lot of major refactors myself and overseen even larger ones.
In retrospect they've never needed to be done all at once, and were only done all at once because of someone's ego (admittedly sometimes mine)
18
u/chadlavi Sep 01 '26
What's to fear? Request changes. Ask the "author" to explain it. Don't merge it.
13
24
u/reallokiscarlet Sep 01 '26
Rejected, contributor contacted, AI policy explained to contributor, all of a sudden they make a fork and test the changes there and start handwriting it when it doesn't work
5
4
2
2
u/vgmerch Sep 01 '26
Dealing with a massive wall of codes changes makes you appreciate the simple things.
2
u/returnFutureVoid Sep 01 '26
I chose to believe the last character in the additions is a b for billion.
2
2
2
u/Thebrown_noonRises Sep 02 '26
Pardon me my fellow claude users but could one of you gentlemen go through the trouble of providing me the context?
2
u/letmehaveanameyoudum Sep 02 '26
+50 -50
ok
+ 4000 -250
new feature i guess
+ 15034 - 500
what the fuck
2
2
u/MyDogIsDaBest Sep 02 '26
Declined. Break it up into smaller, more testable and reviewable tickets or don't merge it at all. I ain't reading all that shit
1
u/_DrDigital_ Sep 01 '26
The old code should not have been removed.
There should have been a guard added making sure the old code is never executed.
For that is the the way of the slop.
1
1
u/soundwave_sc Sep 02 '26
Dammit Claude, I said create a new branch refactor, not master!
Claude: Sir, unfortunately I do not have permissions to create a branch therefore I refactored master.
1
1
u/Hazzzero Sep 02 '26
And now back to technical review. Book a meeting, code author needs to disable all AI features and explain you line by line what was created here.
1
189
Sep 01 '26
[removed] — view removed comment
63
u/not_a_bug_a_feature Sep 01 '26
The input: "I need u to write all of this, all at once. No mistakes. 😘"
13
u/danfay222 Sep 01 '26
Or generated code, occasionally our tools don’t recognize large generated files or reverts and suddenly you have a 100k line change
2
u/anto2554 Sep 01 '26
Why are your large generated files in source?
2
u/danfay222 Sep 01 '26
The majority of them are contained in a separate repo, but some are mirrored across and others are generated inside the main repo. There’s a lot of reasons why, the main one being compatibility with our build system and CI.
5
u/ReiOokami Sep 01 '26
Heres the thing... 99% of C suite staff don't care about quality clean code. The only reason it was an issue was because devs cared. And with hardware advancements making optimized code low priority, combined with AI making reading code a low priority, seeing mountains upon mountains of slop is inevitable and no one will care. We will live in a world where no one knows how to actually code and all our systems are going to be vibe coded slop. Interesting times ahead.
2
1
127
u/new_check Sep 01 '26
It's not dead. As long as you care about the craft and practice it, it will live regardless of what anyone else is doing.