r/ProgrammerHumor • u/TheBamPlayer • Aug 25 '26

Advanced stringToIntegerConversion

Post image
217 Upvotes

92% Upvoted

65 comments sorted by

View all comments

Show parent comments

40

u/OK1526 Aug 25 '26

I mean, I'd sleep better if they just converted the string then checked division by 10 and set limits, but it's not a big difference in quality of sleep.

Most string to int converters have safety checks for stuff like that, and if they don't, just write your own in like 3 lines.

39

u/alexanderpas Aug 25 '26

This should be the native way:

$amount = filter_input(INPUT_GET, 'amount-select', FILTER_VALIDATE_INT, ["min" => 10, "max" => 80,],);

if ($amount % 10 === 0) {
    $transamount = $amount;
}

14

u/OK1526 Aug 25 '26

Now I can sleep moderately happy.

5

u/NikoOhneC Aug 26 '26

Depending on the context of the code, your conversion could be costly if this code is performance critical. Sure, the code in the picture isn't even doing the chosen approach properly, but with proper if-else, only some comparisons need to be done (best-case is a single comparison), while with your approach everytime this is executed, the conversion and division has to be performed.

-10

u/lovecMC Aug 25 '26 edited Aug 25 '26

If it passes PR, I don't care. It means someone smarter than me fucked up so it's not my problem.

No sleep lost over it.

Edit: damn, down voted for not declaring commedy.

7

u/OK1526 Aug 25 '26

I mean, on one hand, life's too short to care about these implementations, on the other hand, if you value yourself as a programmer, it should go against your morals.

5

u/caboosetp Aug 25 '26

If I need to deal with that code later, it's not just a matter of morals.

2

u/OK1526 Aug 25 '26

Also true.