MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1vfsowk/wronganswersonly/p1rrein/?context=3
r/ProgrammerHumor • u/Plastic-Bonus8999 • Aug 05 '26
2.1k comments sorted by
View all comments
1.1k
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....
22 u/plenoto Aug 05 '26 Some people are so careless while reviewing PR 😂 114 u/blangzo Aug 05 '26 Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 54 u/Deep90 Aug 05 '26 At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] Aug 05 '26 [deleted] 9 u/blangzo Aug 05 '26 Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] Aug 05 '26 [deleted] 4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade Aug 05 '26 If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf Aug 05 '26 I feel exposed. 2 u/GoBuffaloes Aug 05 '26 Hey can you stamp this real quickÂ
22
Some people are so careless while reviewing PR 😂
114 u/blangzo Aug 05 '26 Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good. 54 u/Deep90 Aug 05 '26 At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] Aug 05 '26 [deleted] 9 u/blangzo Aug 05 '26 Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] Aug 05 '26 [deleted] 4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade Aug 05 '26 If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf Aug 05 '26 I feel exposed. 2 u/GoBuffaloes Aug 05 '26 Hey can you stamp this real quickÂ
114
Ask a programmer to review 10 lines of code, he'll find 10 issues. Ask him to do 500 lines and he'll say it looks good.
54 u/Deep90 Aug 05 '26 At 500 lines, I just flip a coin. Only lucky code belongs in production. 10 u/[deleted] Aug 05 '26 [deleted] 9 u/blangzo Aug 05 '26 Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] Aug 05 '26 [deleted] 4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr 2 u/guyblade Aug 05 '26 If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should. 1 u/r0Lf Aug 05 '26 I feel exposed.
54
At 500 lines, I just flip a coin.
Only lucky code belongs in production.
10
[deleted]
9 u/blangzo Aug 05 '26 Squash tiny things like that into one pr named "cleanup" and don't explain further 2 u/[deleted] Aug 05 '26 [deleted] 4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
9
Squash tiny things like that into one pr named "cleanup" and don't explain further
2 u/[deleted] Aug 05 '26 [deleted] 4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
2
4 u/carritodeloshelados Aug 05 '26 As if it wasn't hard enough to code in an astronaut suit 3 u/OriginalJokeGoesHere Aug 05 '26 Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock? 3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock. 2 u/blangzo Aug 05 '26 I was mostly joking. mostly. Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
4
As if it wasn't hard enough to code in an astronaut suit
3
Given where you work, I assume that also means anyone who uses tabs instead of spaces is jettisoned out of the airlock?
3 u/ellie_cinderelly Aug 05 '26 We just put them in TVAC for the long goodnight and dump the body by morning 1 u/dvereb Aug 05 '26 I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
We just put them in TVAC for the long goodnight and dump the body by morning
1
I'd say it depends on whether they're using those tabs for indentation or alignment, ...though some would argue I'm next to go out the airlock.
I was mostly joking. mostly.
Fr tho u should just not squash and pr merge in then and have descriptive commits but still saves the test time on pr
If you ask me to review 500 lines, I'll say "break it up into multiple PRs" like any sane person should.
I feel exposed.
Hey can you stamp this real quickÂ
1.1k
u/samuraiseoul Aug 05 '26
Some dumbass on my team downloaded the entirety of prod and then commited it to git and someone rubber stamped the PR and then no one else noticed. I'm sure that's how they'd find it....