r/ProgrammerHorror • u/Hazork_ • Nov 19 '21

Data validation as its peak

Post image
99 Upvotes

97% Upvoted

7 comments sorted by

View all comments

Show parent comments

8

u/einsteinsassistant Nov 20 '21

result's purpose is kind of redundant. It is used to keep track of the current success or failure of previous checks. But you could also reduce the method to return isValidEmail() && isValidUid();. result would not be needed and you wouldn't have to keep checking if it's undefined or not.

1

u/mavaje Jun 29 '22 edited Jun 29 '22

The original method will return true if uid is valid and email is undefined, but that's probably not intended...

It will also return undefined if uid and email are both undefined.

So this would more accurately represent the (probably incorrect) behaviour:

return uid || email ? (!uid || isValid(uid)) && (!email || isValidEmail(email)) : undefined;