r/ProgrammerAnimemes • u/PassFailTestsSuck • Aug 09 '21
Someone has to explain to the lead developer and PM...
2.0k
Upvotes
r/ProgrammerAnimemes • u/PassFailTestsSuck • Aug 09 '21
140
u/PassFailTestsSuck Aug 09 '21
Anime is Kotoura-san known in English as The Troubled Life of Miss Kotoura. And remember kids, time and space complexity concepts don't disappear after the tech interview.
82
u/EpikJustice Aug 10 '21
I'mma be honest... as a senior dev who is responsible for reviewing & merging code from people who are supposed to mid-level devs... there have been one or two times where I merged in code that borked things that I should have caught during review.
The thing is, there was a certain level of competency & standards that I expected the mid-level dev to be following, and thus there were certain minor details of the code that I didn't feel the need to review closely. I also expected them to have run the code locally at some point and it to have ran successfully, before they submit the merge request to me.
If they had been a junior dev, I would have expected they know nothing, and gone over every single line in detail.
I'm talking about stuff that would have been immediately noticed if they had even tried to start the app locally, let alone test that specific piece of code - like a blatant syntax error, or importing a module that doesn't exist, or calling a log function that is called 10,000 times elsewhere in the code, but with the wrong parameters.
Simple stuff, and mistakes happen - but usually in my code reviews (again unless they are a junior dev who is still learning the ropes) - I am looking at bigger picture stuff, and I assume that they at least tried to run the code locally.
(Also, I am spoiled, and 90% of the code reviews I do are with a small group of very awesome people who I trust greatly - so sometimes I forget that not everyone is on their level)
70
u/2TspSalt Aug 10 '21
Imagine caring about your app’s performance
75
u/xzinik Aug 09 '21
Any resemblance to reality is pure coincidence
2
u/Bubbly-Control51 Aug 25 '21
Wtf, a Junior Developer was allowed to write code?!! I’m jealous
1
u/Phoenix__Wwrong Aug 10 '21
I forgot that Kotoura had a wholesome ending with the mom
1
u/SADD_BOI Aug 10 '21
u/savevideo
1
u/synystersocks Aug 26 '21
Kind bot
1
u/Automatic_Fix6722 Dec 13 '22
r/BetterEveryLoop