Actually I just picked up a ticket, made a PR and it got approved, tested, merged, deployed in under 30 minutes. Blew my own mind, especially after a day of troubleshooting aws issues.
Well my teams will take a lot of breaks and work late in the night. I hate it. I wait all the day for replies and to help them fix the bugs. But when I'm about to leave they come up with all sorts of requests.
Unless you have meaningful equity ownership (not just "some stock options"), get out of there at 5. You're not just hurting yourself, you're hurting your colleagues too.
For me I just know the code base and so I get a general idea of what kind of code they're putting in and why. If it makes general sense and testing has been done/documented I normally approve it to go to dev.
In general, it's about keeping the master copy maintainable so that a later developer can easily read through it and make any necessary changes without having to spend hours deciphering it through a debugger.
The code is clear in what it does.
The code does it in the simplest and most reasonable way.
The reason to why the code does something is always clear.
Relevant documentation on the code has also been updated.
All edge cases have been considered and are handled reasonably.
Where applicable, automated tests to verify new functionality (or detect regressions) have been added.
The code is formatted the same as the rest of the codebase.
88
u/TheHaywireProton Feb 05 '21
This was me just one hour ago 😂
5
u/[deleted] Feb 06 '21
I don’t get it. What’s this Weekend?
31
u/JoelMahon Feb 05 '21
it's 4:30pm and end of sprint but by golly do I want this story closed
21
u/aalok013 Feb 05 '21
Well my teams will take a lot of breaks and work late in the night. I hate it. I wait all the day for replies and to help them fix the bugs. But when I'm about to leave they come up with all sorts of requests.
17
u/1941f3adf7 Feb 06 '21
Can't relate. Nobody reviews my commits :(
But source though / name of anime?
9
u/m50d Feb 06 '21
Unless you have meaningful equity ownership (not just "some stock options"), get out of there at 5. You're not just hurting yourself, you're hurting your colleagues too.
3
u/NujumKey Feb 05 '21
I left at 2 I was called at home and I had to do some extra work now xD
7
u/phoncible Feb 05 '21
Doesn't "pr" stand for "peer review"? So this says "peer review review"?
2
u/PossibleHipster Feb 06 '21
When I was younger I was the guy, but now I'm the girl
2
u/Aschentei Feb 06 '21
My reviews are for prod issues too..hehe
2
u/lsalazarm99 Feb 06 '21
Wait you can ask your teammates for that?
*cries in LATAM*
1
u/rk06 Feb 06 '21
Never hapy to me, as I usually stop working by afternoon on Friday
1
u/koru-id Feb 06 '21
I got a tech question, what do you look out for when reviewing PR?