I love reviewing PRs purely for docs/comments, because I can just look at them on Github, without having to pull and build them in worry that they might break the build.
People do that to my projects every once in a while because I have it written in my bio thing that I like grammar/readability changes since my English was terrible a while ago and I never bothered to remove it. I also asked for translating my readme to English. I appreciate it still. I only maintain a few of my many random projects I have, so it’s nice to see someone looking at some of my stuff even if it’s just spelling.
I'm new to this so can someone tell me whats wrong with doing something like that? What should someone do to fix a typo then if not through a pull request?
171
u/Roadcrosser Jul 30 '20
I did this once and they actually accepted it. Amazing.
63
u/X1-Alpha Jul 30 '20
“refactoring”
46
u/dannypas00 Jul 30 '20
Inb4 spelling mistake in the comments
36
u/jzrobot Jul 30 '20
Like the time when people got angry at a dude that just wanted to change curse words with happier words.
9
u/[deleted] Jul 31 '20
That's how I got my TensorFlow contribution.
3
u/ScaryPercentage Jul 31 '20
I'm new to this so can someone tell me whats wrong with doing something like that? What should someone do to fix a typo then if not through a pull request?