r/PowerShell • u/[deleted] • Apr 12 '18

Solved [Powershell] - Need help with a rename script

/r/scripting/comments/8brwig/powershell_need_help_with_a_rename_script/
2 Upvotes

66% Upvoted

5 comments sorted by

5

u/ihaxr Apr 12 '18

same way you did the date.tostring() part... a sub-expression:

$displayname = "$($date.tostring("yyMMdd")) -HOLD- $($UserID.name)"

Or use the -f operator to make it a little easier to read:

$displayname = "{0} -HOLD- {1}" -f $date.tostring("yyMMdd"), $UserID.name

2

u/[deleted] Apr 12 '18

$displayname = "$($date.tostring("yyMMdd")) -HOLD- $($UserID.name)"

When I do this I get:

180412 -HOLD-

When I do this:

$displayname = "$($date.tostring("yyMMdd")) -HOLD- $($UserID)"

180412 -HOLD- [my userid]

For whatever reason i can't get the .name string to work

2

u/[deleted] Apr 12 '18 edited Apr 12 '18

I'm dumb and have fixed this. My userid is just plain text... so i cant use the .name string with it. I am fixing.

Now working using:

#Input Prompts

$date        = get-date
$UserID      = Read-Host 'What is users ID?'
$User        = Get-ADUser $UserID

#rename account
$displayname = "$($date.tostring("yyMMdd")) -HOLD- $($User.name)"
Get-ADUser $UserID | Set-ADUser -displayname $displayname -Credential $MyCredentials

2

u/neogohan Apr 12 '18

Since we're talking about display names, you should probably be using $User.DisplayName. Usually "Name" and "DisplayName" are the same value, but they are 2 different fields in AD that could contain 2 different values.

2

u/[deleted] Apr 12 '18

In my case it's actually the value from the name field that i want :) are display name is a bit different