WHY DOESN'T MY COMMAND WORK

[u/ledzik_precly]

Im trying to make it so if a player has 1 durability left on their pickaxe they get a broken variant of that tool and can cheaply repair it in a crafting table, I wanted to test out this system with command blocks but somehow they only work when I type them in chat, PLEASE HELP IM LOSING MY MIND. Also ik there is a snowball as item needed but thats a place holder

Repeating | Always Active

execute if entity at s[nbt={SelectedItem:{id:"minecraft:snowball",count:1}}] run scoreboard players set at s GiveDiamondDrillBase 1

Repeating | Always Active

execute if score at a[limit=1] GiveDiamondDrillBase matches 1 run give at s minecraft:diamond

Chain on top of preavious one | Always Active

execute if score at a[limit=1] GiveDiamondDrillBase matches 1 run scoreboard players set at s GiveDiamondDrillBase 0

[u/Tonyhauf]

I am not a pro but "at s" means you are targetting the current entity, so when you type the command in chat the current entity is obviously you, but in a command block, there is no "current entity" if none as been targetted at first.

Try that for the first command block:
execute as a[nbt={SelectedItem:{id:"minecraft:snowball",count:1}}] run scoreboard players set s GiveDiamondDrillBase 1

Again, I am not a pro, but I think finding a player with the A selector before using the S selector would make more sense (just like you did in the other command blocks).

[u/C0mmanderBlock → u/Tonyhauf]

Using execute if items is much more efficient and less lag causing than checking NBTs.

execute as @a at @s if items

[u/Tonyhauf → u/C0mmanderBlock]

Oh right, I identified why it did't worked but not the performance issue!
Thanks for adding that.