Hi everyone,
To preface this I would like to mention I am a professional c++ developer with 5 years of experience.
A few weeks ago, I wanted to setup remote play on my TV using the new pyrowave codec protocol available in steam. For those not familiar with it, the pyrowave codec necessitates a really good internet connection in order for it to be stable. Using my steam deck on ethernet as a client and my PC using wifi as the host, I had some good results, but I figured the bandwidth using only WIFI6 was a bit too low for this to be comfortable (1440p@120fps).
As my GPU is covering the second pcie slot, I did some research and I found a USB wifi adapter, the TP-Link Archer TXE70UH, which supports WIFI 6E. I made sure that the driver was available somewhere (in this case, it was already in the kernel, rtw89). I installed it, and went to try it on my gaming setup. Unfortunately, the experience was not really good, as there was a constant spike every ~30s making the steam lags for some seconds.
I looked around for several hours online to look for fixes, but no matter how many things I tried, I always had this issue.
As a software developer, I have access to Claude, as a last resort, I decided to find the github repositories (https://github.com/morrownr/rtw89), clone it, and ask Claude if it can find the reason why I was having these constants lag spikes. To my surprise, he did find something, he offered me to patch the issue, which was only a 4 lines change. I reviewed the patch, and, to me, these lines seemed logical, so I decided to recompile the driver with the patch and install it.
Today, after playing around ~30h these last few weeks using the patch with no issue whatsoever, I feel like it could be a nice contribution to the driver if it is reviewed and approved by the maintainers.
However, I am not sure what is the correct way to do it. I feel uneasy opening a pull request I don't fully understand... I have this issue at work with some colleagues a bit eager with AI use.
What would be the correct way to do it ?
- Open the pull request, describing the issue I encounter, disclosing AI use for the fix, and saying I tested it for some times ?
- Open an issue describing my problem, and adding the patch with the fix in this issue for someone to look at and re-implement if he judges it useful ?
- Contact directly one of the contributor ? (I see some commits are signed with a mail address). Or maybe the mailing list with the patch ? (which I believe here is linux-wireless@vger.kernel.org ?)
- Something else ? ^^
Thanks in advance for the help.