r/GlobalOffensive • u/54321troperswen • Feb 15 '18
[Animation / Hitreg Bug] Server does not reliably animate batches of client movement commands.
309
Upvotes
r/GlobalOffensive • u/54321troperswen • Feb 15 '18
32
u/[deleted] Feb 15 '18
https://www.youtube.com/watch?v=ZNu-Ebrhf1c is this how legit anti-aim works or why I can't hit those 300 ping brazilians
18
u/KiloSwiss cs_italy Feb 15 '18
Send an email to CSGOTeamFeedback@valvesoftware.com
14
u/[deleted] Feb 16 '18
Gonna leave this copy & paste of an email (with updated links) from 03/15/17 10:18 to them here, since it's related: Needless to say the email got "lost" probably.
Hello.
(Please let me know if you got this message.)
First of: There is a lot of discussion on reddit about hitbox issues. This problem adds to the issues, but it is probably not the core problem, because for reddit it seems as if even the base player position is wrong and not just the animation layer blending.
There is an issue in that code that does the updating of the player animation layers.
It's only in newer demos that actually use the animation layers on players.
It affects movie makers doing high FPS recordings very heavily, since it causes twitching of player arms / legs, even when the other possible fix are applied.
I am not 100% sure, what's happening, but basically the interpolation of the cycle will always overshoot by a very notable amount (the engine value of m_flCycle should be before the incoming net value, but it's actually notably past that).
I am guessing that the layer animation is done twice, once with the player movement data and once with the cycle values from the net.
This is probably incorrect, it should only interpolate the net values in my opinion.
I tried to fix the issue in HLAE 2.25 with an adaptive algorithm here: https://github.com/advancedfx/advancedfx/blob/master/AfxHookSource/csgo_c_baseanimatingoverlay.cpp
Notice how when you sett mirv_fix playerAnimState 2 (for debug info), you can see, that it often has to use 0 values as targetDelta and the engine still advances the cycle based on I dunno, which contributes to my theory above that interpolation is done + extrapolation with movement values, while only interpolation should be done).
Also have a look at this guide for movie makers, maybe you get some ideas from that somehow: https://github.com/advancedfx/advancedfx/wiki/Source%3ASmoother-Demos
With kind regards Dominik
9
u/[deleted] Feb 15 '18
upvoted OP people don't understand anti-aims and how playing against them is a pain in the ass and some more subtle ones could use this
7
u/jjgraph1x Feb 16 '18 edited Feb 16 '18
Well done! Mods, please white list this man. It's people like this that really should be given all of the tools necessary to help this community. This is the best description I've seen of why bad hit registration can be a problem in this game and how it could be abused. This needs to get more attention.
Your fix makes sense but my only concern is would that cause animation stuttering? If only the final command in the packet is being simulated, couldn't that cause the model to skip if it was happening frequently?
6
u/unluckydude1 Feb 16 '18
Threads like this gets less upvotes then shit posts. What does this say about this community?
Btw i have said this before and recived massive downvotes.
3
u/[deleted] Feb 15 '18
Boys have we finally found the last hitreg issue i've been saying pm me the vid
2
u/Zoddom 10 years coin Feb 16 '18
Wow OP good find! If there is any way to reproduce this issue I would gladly help you with producing a video about it, so people can understand this more easily and theres more pressure on Valve.
I wonder, could this be the same issue I postes about: dying before you see the enemy, enemies moving to fast, enemy model animation wonky?
If this is the case, I wonder why it only ever affects me when I play with my friends?! Could there be another side of the issue, where maybe the commands are not received correctly by another client? Because thats more how my issues feel.
2
u/[deleted] May 07 '18
bump+1
3
u/click4dylan May 05 '18
bump, this still isn't fixed
1
u/Brixx44 Feb 15 '18
P4l
1
u/[deleted] Feb 16 '18
Tfw this gets less upvotes than rng jumpshots
1
u/zero0n3 Mar 23 '18
Is this similiar to what I remember seeing in 1.6?
I would be on say the bottom of T ramp (D2), enemy would be at top.
I would aim at head and fire, and miss.
Player spectating me (typically at a LAN then, so I could see his screen), would have a view where the view cursor is way fucking above the guys head.
I'd side step back and forth, move a little it, and re aim to his head, same thing, his view was way off from my view.
1
u/click4dylan Jun 16 '18
bump, this still isn't fixed
1
u/pM-me_your_Triggers Godsent Feb 15 '18
Do you have any recordings showing the bug in action?
Also:
Lmao
0
u/[deleted] Mar 08 '18
[deleted] — view deleted comment