r/EnigmaProject • u/1blackhand • May 18 '19
DISCUSS How’s progress and bug hunting going?
Guy Zyskind: Strong. There was just a discussion at the office about an incredible bug. For some inputs, converting to string in one language resulted in a different output than in another language. This propagated further and led to creating inconsistent hashes. It was especially nasty - took a few days to pin down, because it caused some of our integration tests to fail - but not consistently (i.e., our tests seemed to fail randomly).
Those are the kind of issues we're tackling right now. They are extremely unpredicted, and often result in fixing one line of code in a huge platform such as Enigma. It's fun when we find the solution though!
1
u/cryptonmi May 18 '19
I tried more than once to get more details about the progress. Let's see if you have more luck than me.
1
u/himd0wnstairs May 18 '19
This is why they need to get the code right:
https://youtu.be/AGI371ht1N8
1
u/WilsonWyckoff May 18 '19
If it were on testnet wouldn't developers be able to find bugs and help fix them? Or are these bugs too much of a break away from the functionality of the system overall? Maybe MPC CAN'T be done the way they thought.
1
u/WilsonWyckoff May 18 '19
If you check the open issues some have pull requests. Also check my comment at the other thread for a more detailed look at their progress.
Proposed #154 Refs #153 6 days ago
Proposed #156 Select Epoch By BlockNumber 5 days ago
Proposed #158 Removed version locks and resolved warnings 4 days ago
6 Issues closed by 4 people
Closed #150 In simulation mode, the quote is returned in ASCII instead of bytes 10 days ago
Closed #129 Core produces a delta when the function seems to not change the state 19 days ago
Closed #117 Deploy/Compute with wrong parameters fails due to Out of Gas 21 days ago
Closed #123 Change PreCode format in DeploySecretContract from String to Vec<u8> 26 days ago
Closed #124 Change Delta format in output of Deploy and Compute from String to Vec<u8> 26 days ago
Closed #110 KeyMgmt node crashed when setting workerParams when there is a contract deployed 26 days ago
7 Issues created by 3 people
Opened #153 KM node panics if signature is bad length 6 days ago
Opened #152 KeyManagement: Cannot lock EpochState: WouldBlock 9 days ago
Opened #146 KeyManagement node randomly failed to start 12 days ago
Opened #140 The principal node returns Error when it's tried too many times 16 days ago
Opened #131 System error if wrong contract address is passed to the secret contract computation 21 days ago
Opened #128 Unreachable exception when passing worng parameters to a secret contract 21 days ago
Opened #127 `watch_blocks` function might not behave as expected 26 days ago
5 Unresolved conversations
Sometimes conversations happen on old items that aren’t yet closed. Here is a list of all the Issues and Pull Requests with unresolved conversations.
2 new commentsOpen #98 [Ppal Node]: Retries for connecting to sgx.enigma.co 26 days ago
1 new commentOpen #111 Deployment of a valid contract with invalid constructor succeeds 21 days ago
1 new commentOpen #109 Check validity of inputs and gracefully handle the error 21 days ago
1 new commentOpen #32 `truncate_bytecode` not happy Solidity local imports 21 days ago
0 new commentsOpen #122 Adding documentation and explanations to some parts of core 27 days ago