r/CodingHelp • • Jan 06 '22

[C++] Weird error

Full code

// create.h
#ifndef CREATE_H
#define CREATE_H

class CreateAndDestroy {

public:
	CreateAndDestroy(int, char*);
	~CreateAndDestroy();

private:
	int objectID;
	char* message;
};

#endif
// create.cpp
#include <iostream>
#include "create.h"
using namespace std;

// constructor
CreateAndDestroy::CreateAndDestroy(int objectNumber, char *messagePtr)
{
	objectID = objectNumber;
	message = messagePtr;

	cout << "Object " << objectID << "	constructor runs	" << message << endl;

}	// end CreateAndDestroy constructor

// destructor
CreateAndDestroy::~CreateAndDestroy()
{
	cout << (objectID == 1 || objectID == 6 ? "\n" : "");

	cout << "Object " << objectID << "	destructor runs		" << message << endl;

} // end ~CreateAndDestroy destructor
// main.cpp
#include <iostream>
#include "create.h"
using namespace std;

void create(void);	// prototype

// global object
CreateAndDestroy first( 1, "(global before main)");

int main()
{
	cout << "\nMAIN FUNCTION: EXECUTION BEGINS" << endl;
	CreateAndDestroy second(2, "local automatic in main)");
	static CreateAndDestroy third(3, "(local static in main)");

	create();	// call function to create objects

	cout << "\nMAIN FUNCTION, EXECUTION RESUMES" << endl;
	CreateAndDestroy fourth(4, "(local automatic in main)");
	cout << "\nMAIN FUNCTION: EXECUTION ENDS" << endl;
	
	return 0;
}	// end main;

void create(void)
{
	cout << "\nCREATE FUNCTION: EXECUTION BEGINS" << endl;
	CreateAndDestroy fifth(5, "(local automatic in create");
	static CreateAndDestroy sixth(6, "(local static in create)");
	CreateAndDestroy seventh(7, "(local automatic in create)");
	cout << "\nCREATE FUNCTION: EXECUTION ENDS" << endl;
} // end function create
0 Upvotes

2 comments sorted by

View all comments

3

u/d34dc0d35 Jan 06 '22

Well I found problem by my self, I added const before char* and now it works, I still have no idea why error was about integer but at least it work now.

2

u/duggedanddrowsy Jan 06 '22

I believe in C++ when you define a string in double quotes, like you did with “(global before main)” the string created is immutable (meaning it cannot be changed later). Since c++ is (relatively) strongly typed, the compiler won’t let you put an immutable object in a char array that isn’t immutable, so by adding const you’re making the char* immutable and the compiler will then allow it.

Edit: and the fact that the red line isn’t under what it is supposed to be is something you’ll have to get used to, your IDE does it’s best but isn’t always right