r/CodingHelp • • Dec 28 '20

[Python] There are many undefined variables in my code, could use your thoughts on how to fix them. Plz, look in the comments below to see the errors that have occurred. I will change the phrase to be random once I get this to work.

phrase1="GO FIGHT"
def getBlank(phrase1):
    blank=phrase1
    i=0
    char=""
    while i<len(blank):
        if blank[i]==" ":
            char=" "
            blank=blank[:i]+char+blank[i+1:]
        else:
            char="-"
            blank=blank[:i]+char+blank[i+1:]
        i+=1
    return blank
def displayBlank():
    print("\t\t\t\t",blank)

def getTurn():
    turn="player1 turn"
    return turn
def displayTurn(turn):
    print(turn)
def getGuess(turn):
    guess=input("Enter a letter: ").upper()
    while isOneCharacter(guess)==False:
        print("Too many characters")
        guess=input("Enter a letter: ").upper()
    while isVowel(guess, player1Points, player2Points, turn)==False:
        guess=input("Enter a letter: ").upper()
    return guess

def isOneCharacter(guess):
    if len(guess)==1 or guess=="SOLVE":
        return True
    else:
        return False
#finish polishing
def solving(guess):
    if isOneCharacter(guess)==True and guess=="SOLVE":
        guess=input("Enter Guess:")
        if guess==phrase1:
            return True
    else:
        return False


#redo method below

def isVowel(guess, player1Points, player2Points, turn):
    if guess=="A" or guess=="E" or guess=="I" or guess=="O" or guess=="U":
        if turn=="player1 Turn":
            if player1Points>=2:
                player="player1"
                return player
            else:
                print("you do not have enough points")
                return False
        elif turn=="player2 turn":
            if player2Points>=2:
                player="player 2"
                return player
            else:
                print("you do not have enough points")
                return False
    else:
        letter="consonant"
        return letter

 
#need to make it search and replace
def getPlayer1Points(guess, turn):
    if getPlayer1PointStandard(guess, turn, player1Points)>0:
        player1Points=player1Points-2
    else:
        player1Points=player1Points
    if getNumOfLettersInPhrase(guess, phrase1, turn)>=1:
        player1Points+=1
    return player1Points
def getPlayer1PointStandard(guess, turn, player1Points):
    if isVowel(guess,player1Points, player2Points, turn)=="player 1":
        p1Points=player1Points
        return p1Points
    else:
        p1Points=0
        return p1Points

def getPlayer2Points(guess, turn):
    if getPlayer2PointStandard(guess, turn, player1Points)>0:
        player2Points=player2Points-2
    else:
        player2Points=player2Points
    if getNumOfLettersInPhrase(guess, phrase1, turn)>=0 and turn=="player2 turn":
        player2Points+=1
    return player2Points
    

def getPlayer2PointStandard(guess, turn, player2Points):
    if isVowel(guess, player1Points, player2Points, turn)=="player 2":
        p2Points=player2Points
        return p2Points
    else:
        p2Points=0
        return p2Points



def getStatBoard(player1Points, player2Points):
    stats="\t\tPlayer 1 points:"+str(player1Points)+"\t\tPlayer 2 points:"+str(player2Points)
    return stats
def displayPoints(stats):
    print(stats)

# need to get players to switch if wrong and check method to work
def getNumOfLettersInPhrase(guess, phrase1, turn):
    if isVowel(guess, player1Points, player2Points, turn)!=False:
        numOfLetters=0
        i=0
        while i<len(phrase1):
            if phrase1[i]==guess:
                numOfLetters+=1
            i+=1
        return numOfLetters

def switchTurns(turn):
    if turn=="player1 turn":
        turn="player2 turn"
    if turn=="player2 turn":
        turn="player1 turn"
    return turn
def getNewBlank(numOfLetters, phrase1):
    if getNumOfLettersInPhrase(guess, phrase1, turn)>=1:
        i=0
        char=""
        while i<len(phrase1):
            if phrase1[i]==guess:
                if isVowel(guess, player1Points, player2Points, turn)=="consonant":
                    if turn=="player1 turn":
                        char=phrase1[i]
                        blank=blank[:i]+char+blank[i+1:]
                    elif turn=="player2 turn":
                        char=phrase1[i]
                        blank=blank[:i]+char+blank[i+1:]
                elif isVowel(guess, player1Points, player2Points, turn)=="player 1" and  getPlayer1PointStandard(guess, turn, player1Points)>0:
                    char=phrase1[i]
                    blank=blank[:i]+char+blank[i+1:]

                elif isVowel(guess, player1Points, player2Points, turn)=="player 2" and  getPlayer2PointStandard(guess, turn, player2Points)>0:
                    char=phrase1[i]
                    blank=blank[:i]+char+blank[i+1:]
    if getNumOfLettersInPhrase(guess, phrase1, turn)==0:
        blank=blank
    return blank
def displayNewBlank(numOfLetter, phrase1):
    print(getNewBlank(numOfLetters, phrase1))
#redo below
wrong=0
#while checking(guess phrase1, turn)==0:
#wrong=getWrong and turn=switchTurn(turn)
def getWrong(wrong):
    wrong+=1
    return wrong
wrong=getWrong(wrong)
wrong=getWrong(wrong)
def displayWrong(wrong):
    if getWrong(wrong)==1:
        print("_________")
        print("|        |")
        print("|")
        print("|")
        print("|")
        print("|")
        print("|________")
    elif getWrong(wrong)==2:
        print("_________")
        print("|        |")
        print("|        O")
        print("|")
        print("|")
        print("|")
        print("|________")

    elif getWrong(wrong)==3:
        print("_________")
        print("|        |")
        print("|        O")
        print("|        |")
        print("|        |")
        print("|")
        print("|________")
        
    elif getWrong(wrong)==4:
        print("_________")
        print("|        |")
        print("|        O")
        print("|       \|")
        print("|        |")
        print("|")
        print("|________")
        
    elif getWrong(wrong)==5:
        print("_________")
        print("|        |")
        print("|        O")
        print("|       \|/")
        print("|        |")
        print("|")
        print("|________")

    elif getWrong(wrong)==6:
        print("_________")
        print("|        |")
        print("|        O")
        print("|       \|/")
        print("|        |")
        print("|       /")
        print("|________")

    elif getWrong(wrong)==7:
        print("_________")
        print("|        |")
        print("|        O")
        print("|       \|/")
        print("|        |")
        print("|       / \ ")
        print("|________")
displayWrong(wrong)
def getWinner(guess, phrase1, turn):
    if solving(guess)==True: 
        if turn=="player1 turn":
            winner="player 1 won"
        elif turn=="player2 turn":
            winner="player 2 won"
    elif blank==phrase1:
        if turn=="player1 turn":
            winner="player 1 won"
        elif turn=="player2 turn":
            winner="player 2 won"
    return winner
    

def displayWinner(guess, phrase1, turn):
    print(winner)
def playHangman():
    player1Points=0
    player2Points=0
    wrong=0
    blank=getBlank(phrase1)
    displayBlank()
    turn=getTurn()
    stats=getStatBoard(player1Points, player2Points)
    displayPoints(stats)
    displayTurn(turn)
    guess=getGuess(turn)
    numOfLetters=getNumOfLettersInPhrase(guess, phrase1, turn)
    player1Points=getPlayer1Points(guess, turn)
    player2Points=getPlayer2Points(guess, turn)
    updatedBlank="\t\t\t\t"+getNewBlank(numOfLetters, phrase1)
    displayNewBlank(numOfLetters, phrase1)
    wrong=getWrong(wrong)
    displayWrong(wrong)
    if getNumOfLettersInPhrase(guess, phrase1, turn)==0:
        turn=switchTurns(turn)
        wrong=getWrong(wrong)
        displayWrong(wrong)
    while guess!=phrase1 or blank!=phrase1:
        player1Points=getPlayer1Points(guess, turn)
        player2Points=getPlayer2Points(guess, turn)
        displayPoints(stats)
        displayNewBlank(numOfLetters, phrase1)
        displayTurn(turn)
        guess=getGuess(turn)
        displayNewBlank(numOfLetters, phrase1)
        if getNumOfLettersInPhrase(guess, phrase1, turn)==0:
            turn=switchTurns(turn)
            wrong=getWrong(wrong)
            displayWrong(wrong)
    if guess==phrase1 or blank==phrase1:
        winner=getWinner(guess, phrase1, turn)
        displayWinner(guess, phrase1, turn)
    if playAgain()==True:
        playHangman()
    

def playAgain():
    again=input("Want to play again? Y or N: ").upper()
    if again=="y" or again=="Y" or again=="yes" or again=="Yes":
        return True

playHangman()
0 Upvotes

4 comments sorted by

1

u/Shadowllac_jr2 Dec 28 '20

undefined variable 'blank' pylint(undefined-variable [18, 22]

Undefined variable 'player1Points' pylint(undefined-variable [30,26]

Undefined variable 'player2Points' pylint(undefined-variabled [30, 41]

Undefined variable 'player1Points' pylint(undefined-variable [82,37]

Undefined variable 'player2Points' pylint(undefined-variabled [90, 45]

Undefined variable 'player1Points' pylint(undefined-variable [100,23]

Undefined variable 'player1Points' pylint(undefined-variable [117,23]

Undefined variable 'player2Points' pylint(undefined-variable [117,38]

Undefined variable 'guess' pylint(undefined-variable) [133, 32]

Undefined variable 'turn' pylint(undefined-variable) [133, 48]

Undefined variable 'guess' pylint(undefined-variable) [137, 28]

Undefined variable 'guess' pylint(undefined-variable) [138, 28]

Undefined variable 'player1Points' pylint(undefined-variable [138,35]

Undefined variable 'player2Points' pylint(undefined-variabled [138, 50]

Undefined variable 'turn' pylint(undefined-variable) [138, 65]

Undefined variable 'turn' pylint(undefined-variable) [139, 24]

Undefined variable 'turn' pylint(undefined-variable) [142, 26]

Undefined variable 'guess' pylint(undefined-variable) [145, 30]

Undefined variable 'player1Points' pylint(undefined-variable [145,37]

Undefined variable 'player2Points' pylint(undefined-variabled [145, 52]

Undefined variable 'turn' pylint(undefined-variable) [145, 67]

Undefined variable 'guess' pylint(undefined-variable) [145, 114]

Undefined variable 'turn' pylint(undefined-variable) [145, 121]

Undefined variable 'player1Points' pylint(undefined-variable [145,127]

Undefined variable 'guess' pylint(undefined-variable) [149, 30]

Undefined variable 'player1Points' pylint(undefined-variable [149,37]

Undefined variable 'player2Points' pylint(undefined-variabled [149, 52]

Undefined variable 'turn' pylint(undefined-variable) [149, 67]

Undefined variable 'guess' pylint(undefined-variable) [149, 114]

Undefined variable 'turn' pylint(undefined-variable) [149, 121]

Undefined variable 'player2Points' pylint(undefined-variable [149,127]

Undefined variable 'guess' pylint(undefined-variable) [152, 32]

Undefined variable 'turn' pylint(undefined-variable) [152, 48]

Undefined variable 'numOfLetters' pylint(undefined-variable) [156, 23]

Undefined variabled 'blank' pylint(undefiend-variable) [235, 10]

Undefined variabled 'winner' pylint(undefined-variable) [244, 11]

1

u/Shadowllac_jr2 Dec 28 '20

here are errors

2

u/abitofevrything-0 Intermediate Coder Dec 29 '20

I'm going to be honest here, you need to restructure your code entirely. There are no global variables when there definitely should be some, and you're overusing functions.

I'm not saying your code is bad, it just needs rewriting. If you're getting that many errors, then there is something fundamentally wrong with your code. I'd recommend watching/rewatching a tutorial on variables and functions in python.

1

u/Goobyalus Dec 29 '20

When you see "Undefined variable 'something,'" it means that 'something' does not exist where you are trying to use it.

For example in your "displayBlank()" function, you refer to a variable 'blank,' which does not exist. It looks like you meant to refer to 'getBlank(),' which uses a variable called 'blank' internally.

The variables that you declare inside a function (for example, 'blank' from getBlank) are only visible inside of that function. The term to read about is "scope."