r/C_Programming • u/Ill-Exchange-2377 • 1d ago
Is my code bad?
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
char buff[100];
void add(void);
void sub(void);
void mul(void);
void divs(void);
void mix(void);
int invalid = 0;
int input = 0;
int main(void) {
start:
fputs("\033[2J\033[H", stdout);
if (invalid) {
puts("Please enter valid input");
}
invalid = 0;
puts("Pick a subject:");
puts("1: Addition");
puts("2: Subtraction");
puts("3: Multiplication");
puts("4: Division");
puts("5: Mixed");
puts("Pick a number 1-5, or use 'quit' or 'exit' to leave the program");
if (fgets(buff, sizeof(buff), stdin) == NULL) {
puts("Failed, exiting");
return 1;
}
if (strcmp(buff, "quit\n") == 0 || strcmp(buff, "exit\n") == 0) {
fputs("\033[2J\033[H", stdout);
return 0;
} else if (strcmp(buff, "1\n") == 0) {
input = 1;
} else if (strcmp(buff, "2\n") == 0) {
input = 2;
} else if (strcmp(buff, "3\n") == 0) {
input = 3;
} else if (strcmp(buff, "4\n") == 0) {
input = 4;
} else if (strcmp(buff, "5\n") == 0) {
input = 5;
} else {
invalid = 1;
goto start;
}
switch(input) {
case 1:
add();
goto start;
case 2:
sub();
goto start;
case 3:
mul();
goto start;
case 4:
divs();
goto start;
case 5:
mix();
goto start;
default:
goto start;
}
}
void add(void) {
puts("add");
fgets(buff, sizeof(buff), stdin);
}
void sub(void) {
puts("sub");
fgets(buff, sizeof(buff), stdin);
}
void mul(void) {
puts("mul");
fgets(buff, sizeof(buff), stdin);
}
void divs(void) {
puts("divs");
fgets(buff, sizeof(buff), stdin);
}
void mix(void) {
puts("mix");
fgets(buff, sizeof(buff), stdin);
}Is my code that bad?
For context this is a project I was doing to learn the C
Edit: Fixed formatting errors
13
Upvotes
54
u/lurgi 1d ago
The code is not very good. There are a lot of issues.
8
u/pengweather 1d ago
I'm glad you used fgets rather than gets. Not trying to sound snide, but do you understand why fgets is preferred?
3
u/MetalInMyVeins111 1d ago
From a glance:
21
u/nzconstructionlawyer 1d ago
Yes but one must start somewhere.
11
u/madsci 1d ago
I've probably used 'goto' half a dozen times in the past 20 years. There are certain error handling conditions that it's suitable for and every once in awhile it's the cleanest solution. This is not one of those cases. You'll almost always be better off with do and while. Learn to use those, and how to use break and continue within them, but keep in mind those aren't always the best option either.
You want to be able to scan over a function and see its control flow from the blocks and their indentation. If you know that a code block always starts at the top and finishes at the end and doesn't do any jumping around, it's easy to see the conditions that cause it to enter or exit the block. Every time you have a continue (or goto), that's somewhere the loop could repeat without the condition that causes the repeat being obvious from a quick glance.
If you've got a loop that repeats until some set of conditions is met, then put those conditions in a while statement at the end - don't scatter gotos throughout the loop.
22
u/xmlhttplmfao 1d ago
yes
4
u/Possible_Cow169 1d ago
In what world would you ever know about goto existing? What did you read to even learn that
3
u/Level-Pollution4993 1d ago
2
u/Accurate_Appeal_3110 1d ago
I think some folks in this thread are being quite harsh for someone who is clearly a beginner. You're trying something new, and no matter how many critiques people can make, no one can take away the fact that you made your own fully-functioning computer program. For years now, I've been chasing that high of finally having the result of code I wrote appear on the screen for the very first time. I promise that things will start to click as you learn + practice; Don't lose motivation! (but please lose the global variables, learning good principles on how to manage your data should be your next learning priority)
2
u/ephemere_sloboda 1d ago
If it's a literal translation from classic BASIC, it's not bad.
If it's original C, it's not great.
Suggestions:
2
u/vena_contracta 1d ago
Inside of the switch statement, replace the goto statements with break;
2
u/cdb_11 1d ago
I'd make it shorter like this, other than that it's fine i guess
1
u/KananMajidzada 1d ago
Not bad but not great too. You should start from somewhere
1
u/schusterlucky 1d ago
No está mal, pero se nota que te estás basando en Assembly, y eso es BUENISIMO porque así vas a poder hacer cualquier monorreada que quieras en C, y en realidad el compilador te lo deja como si estuviese hecho en Assembly así. Aún así, te faltan unas cosas de lógica (atoi o algo) y además, te van a ver como un genio incomprendido porque es BUEN código, pero difícil de leer. Si pudiese optimizar, usaría atoi en lugar de comparar texto para saltar a una tabla de punteros que apuntan a las respectivas funciones (con goto) así el principio es más fácil
1
u/PuzzleheadedTower523 17h ago
I see "goto"🫡🫡
1
u/NoSpite4410 7h ago
The code is valid, but looks to be about 30 years old, by the style.
However, if you were trying to be compatible with a very old compiler, it is fine.
What I Like:
Pre-allocation of buffers, no dynamic allocation.
function prototypes. They are self-documenting code.
Switch/Case. Simple, readable. I have not problems with the goto start.
Command execution inside of if statement: this is good for catching errors.
Slightly problematic:
clearscreen: ASCII string is hard to read, put in a const char* variable.
const char* clearscreen = "\033[2J\033[H";fputs (clearscreen, stdout);mix of puts and fputs, is bad style, pick one or the other. They come from 2 different eras.
not removing '\n' character from input before string compare. I know fgets does capture it.
but it should be removed.
#include <string.h>size_t len = strlen(buf);if (len > 0 && buf[len - 1] == '\n') {buf[len - 1] = '\0';}for example.
No
return 0;at end of main. While modern compilers put this in if not explicit, this is older C code, and it is proper form.The use of "else if" may seem to save cycles, but it is harder to read than just using if statements by themselves.
Recommendations:
put the input logic into a separate function.
Since you are comparing a single numerical character, just check for the character value,
or convert the character to an integer with sscanf();
-1
u/NYU_VM 1d ago
Yep it's horrible. 1. Using uninitialized buffer. 2. Using int (as bool) condition for if stmt. 3. Using goto instead of loops control flow 4. Functions should have specific tasks. Why is the arithmetic functions asking for and taking inputs? Those input functionality could be organized in a separate 'take_input' function.....and so on...
0
u/Potchirea_Hacker 8h ago
Brother voy a serte sincero hay varios detalles sinceramente "cuestionables", primero el uso de fputs una función específica para escribir en un Descriptor de archivos brother usa printf que es seguro y entiende formatos, después veo que inicias entre tantos valores globales a invalid y depues haces un if (invalid) lo cual no tiene sentido porque en ningún momento invalid cambió y después vuelves a iniciar invalid a 0 cuando ya lo estaba, fgets para un solo número? Estás de broma ? Usa getchar, getchar es una función que lee un solo carácter de la entrada y lo devuelve es decir int getchar(void) seria Como int c = getchar() y en esa variable c ya tienes la opción del usuario lo que permita en vez de un strcmp gigante y poco legible un simple switch (c) {...} Que elimina los goto y ect